Conversation
| print("\n❌ Evaluator is not ready within the timeout period.") | ||
| print(f"📊 Please check the evaluator status at: {dashboard_url}") | ||
| print(" Wait for it to become ACTIVE, then run 'eval-protocol create rft' again.") | ||
| return 1 |
There was a problem hiding this comment.
Bug: Evaluator polling errors allow unconfirmed readiness progression
If the evaluator status polling (lines 406-421) raises an exception, it will be caught by the exception handler at line 424, which only prints a warning and allows execution to continue. This means the RFT job creation will proceed even though the evaluator's readiness was never confirmed. The polling logic should either be outside the try-except block, or the exception handler should check whether polling completed successfully before continuing.
| print("\n❌ Evaluator is not ready within the timeout period.") | ||
| print(f"📊 Please check the evaluator status at: {dashboard_url}") | ||
| print(" Wait for it to become ACTIVE, then run 'eval-protocol create rft' again.") | ||
| return 1 |
There was a problem hiding this comment.
Bug: Evaluator Upload Failure: Stop With Error Code
When evaluator upload fails (rc != 0), the function prints a warning but continues execution instead of returning an error code. This causes the function to proceed with RFT job creation using a potentially non-existent or failed evaluator, which will likely fail. The code should return 1 (or the actual error code) when upload fails, similar to the error handling at line 421 when the evaluator is not active.
Note
Adds --force to
create rft, passes it through to upload, and polls evaluator status until ACTIVE before proceeding, failing with a dashboard link on timeout.--forceflag tocreate rftto allow overwriting an existing evaluator.--forcethrough touploadand log when used; includeenv_file=Nonein upload args.GET /v1/accounts/.../evaluators/{id}withUser-Agentheader untilACTIVE(or timeout/BUILD_FAILED).Written by Cursor Bugbot for commit 68c7a2d. This will update automatically on new commits. Configure here.