Skip to content

upload from input dataset as well#306

Merged
benjibc merged 1 commit intomainfrom
upload_from_input_dataset
Nov 1, 2025
Merged

upload from input dataset as well#306
benjibc merged 1 commit intomainfrom
upload_from_input_dataset

Conversation

@benjibc
Copy link
Copy Markdown
Contributor

@benjibc benjibc commented Nov 1, 2025


name: Pull Request
about: Propose changes to the codebase
title: "Brief description of changes"
labels: ''
assignees: ''


Description

Please include a summary of the change and which issue is fixed or feature is implemented. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)
Implements # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Refactoring/Code cleanup
  • Build/CI/CD related changes
  • Other (please describe):

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

  • Test A
  • Test B

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project (ran black ., isort ., flake8 .)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Screenshots (if applicable)

If applicable, add screenshots to help showcase your changes.

Additional context

Add any other context about the PR here.


Note

Enable create_rft to infer and upload dataset JSONL from tests using input_dataset (dataset_path) in addition to data_loaders, and update example test accordingly.

  • CLI (eval_protocol/cli_commands/create_rft.py):
    • Add _extract_jsonl_from_input_dataset to resolve JSONL from input_dataset/dataset_path in parametrized tests (handles relative/absolute paths and lists).
    • Enhance dataset inference: try data_loaders first, then fall back to input_dataset; update error message accordingly.
  • Tests:
    • Update GSM8K example to use input_dataset=[JSONL_PATH] instead of EvaluationRowJsonlDataLoader.

Written by Cursor Bugbot for commit 715beea. This will update automatically on new commits. Configure here.

@benjibc benjibc merged commit d8477be into main Nov 1, 2025
9 checks passed
@benjibc benjibc deleted the upload_from_input_dataset branch November 1, 2025 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant