Skip to content

Revert "add default try catch to evaluator function"#301

Merged
mayinghan merged 1 commit intomainfrom
revert-297-try-catch-on-eval-func
Oct 29, 2025
Merged

Revert "add default try catch to evaluator function"#301
mayinghan merged 1 commit intomainfrom
revert-297-try-catch-on-eval-func

Conversation

@mayinghan
Copy link
Copy Markdown
Collaborator

@mayinghan mayinghan commented Oct 29, 2025

Reverts #297


Note

Removes default try/except around execute_pytest in evaluation_test, letting exceptions surface, and drops the unused EvaluateResult import.

  • Pytest evaluation runtime:
    • Remove error-wrapping try/except around execute_pytest in both pointwise and groupwise paths of eval_protocol/pytest/evaluation_test.py; directly await execute_pytest and validate return types.
  • Models/Imports:
    • Drop EvaluateResult import from eval_protocol.models in evaluation_test.py.

Written by Cursor Bugbot for commit 5dca8be. This will update automatically on new commits. Configure here.

@mayinghan mayinghan merged commit 56e00c2 into main Oct 29, 2025
1 check passed
@mayinghan mayinghan deleted the revert-297-try-catch-on-eval-func branch October 29, 2025 20:32
mayinghan added a commit that referenced this pull request Oct 29, 2025
mayinghan added a commit that referenced this pull request Oct 30, 2025
* Revert "Revert "add try catch (#297)" (#301)"

This reverts commit 56e00c2.

* set the eval metadata status as well

* add

* lint

* add

* add

* avoid override

* fix ut

* add
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant