Integrate eval protocol to rllm trainer#292
Merged
1stprinciple merged 8 commits intomainfrom Oct 27, 2025
Merged
Conversation
| max_tokens=max_tokens, | ||
| **extra_body, | ||
| **other_params, | ||
| ) |
There was a problem hiding this comment.
Bug: Server Cleanup Fails on Policy Creation Error
Policy initialization code was moved outside the exception handling block. When start_server=False (retry scenario), if policy creation fails (lines 242-260), there is no exception handler to clean up the server that was started in a previous call. This can leave the MCP server running indefinitely without cleanup, causing resource leaks. The exception handler at lines 228-233 only catches exceptions during server.start() when start_server=True, not during policy creation when start_server=False.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Guard signal handler registration to main thread and move LiteLLM policy initialization outside server start for consistent retries and setup.
default_mcp_gym_rollout_processor.py):threading.current_thread()checks.threadingimport.LiteLLMPolicycreation to occur after server start (and on retries), rather than inside the server start block.serveronly (nopolicycheck).policy.Written by Cursor Bugbot for commit 339e8ce. This will update automatically on new commits. Configure here.