Conversation
mayinghan
approved these changes
Oct 25, 2025
mayinghan
reviewed
Oct 25, 2025
| f"Upload attempt {attempt + 1}/{max_retries} failed: {e}. " | ||
| f"Retrying in {wait_time}s..." | ||
| ) | ||
| time.sleep(wait_time) |
Collaborator
There was a problem hiding this comment.
consider to remove this manual retry handler, wrap the function that you want to have retry and use a decorator. but this can be done in a followup pr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for GCS upload and changed test-discovery
Changes in test-discovery function -
(Issues with older test_discovery)
Solution - Fixed it by using the pytest internal collector mechanism, (mainly uses our discoverability, just handles modules better)
New upload flow -
3 endpoints
We call the first entry point with entry function name, then second endpoint after compressing the entire current workingdirectory (we ignore file names listed in .gitignore and .dockerignore, also submit the git hash in pep440 for versioning) then validateUpload after the directory upload has finished.
The developer has to take care of the following things when using ep upload -
You will need to have a requirements.tx in your pwd before running ep upload. (else we don't continue with the upload)
We are ignoring all file patterns stated in .gitignore/.dockerignore while pushing evaluator code for the run
It is recommended to git commit before running ep upload, so that we can version properly and it is easy for the developer to track back the evaluator code version.
Note
Reworks test discovery to use pytest collection and changes evaluator creation to upload a tar.gz of the project to GCS via new V2 endpoints with validation.
--collect-only) to discover@evaluation_testfunctions; ignore problematic files (e.g.,setup.py, hidden, test_discovery*).pytestmarkobjects; extract parametrization info; generate stable nodeids and entry points..../evaluatorsV2→:getUploadEndpoint→:validateUpload.criteria(no embedded code); includeparent,commitHash(pep440), andentryPointwhen provided.requirements.txt; create tar.gz of CWD honoring.gitignore/.dockerignore; upload to GCS via signed URL with retries; validate upload.requirements.txt; improve cleanup withshutil.rmtree.Written by Cursor Bugbot for commit a766d40. This will update automatically on new commits. Configure here.