Skip to content

completion params instead of model#281

Merged
shreymodi1 merged 11 commits intomainfrom
completionparams
Oct 21, 2025
Merged

completion params instead of model#281
shreymodi1 merged 11 commits intomainfrom
completionparams

Conversation

@shreymodi1
Copy link
Copy Markdown
Contributor

Add support for arbitrary completion params in RemoteRolloutProcessor [FIR-5739]

Main logic change -

  1. Removed model in InitRequest
  2. RemoteRolloutProcessor now passes completion params. Row-level overrides config-level completion params.
  3. All test servers now retrieve model from completion params
  4. Changed typescript servers similarly

Copy link
Copy Markdown
Contributor

@xzrderek xzrderek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! let dylan / benny take a look and they should be the approver

Copy link
Copy Markdown
Contributor

@xzrderek xzrderek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fire

Copy link
Copy Markdown
Collaborator

@dphuang2 dphuang2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@shreymodi1 shreymodi1 merged commit 695632c into main Oct 21, 2025
14 of 15 checks passed
@shreymodi1 shreymodi1 deleted the completionparams branch October 21, 2025 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants