Skip to content

rename param for RemoteRolloutProcessor #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dphuang2 merged 2 commits into from
Oct 10, 2025
Merged

rename param for RemoteRolloutProcessor #270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ff43edc
rename
Oct 10, 2025
519bbab
update ElasticsearchConfig
Oct 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions eval_protocol/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
from .log_utils.rollout_id_filter import RolloutIdFilter
from .log_utils.util import setup_rollout_logging_for_elasticsearch_handler
from .log_utils.fireworks_tracing_http_handler import FireworksTracingHttpHandler
from .log_utils.elasticsearch_client import ElasticsearchConfig


from .types.remote_rollout_processor import (
Expand Down Expand Up @@ -75,6 +76,7 @@
warnings.filterwarnings("default", category=DeprecationWarning, module="eval_protocol")

__all__ = [
"ElasticsearchConfig",
"ElasticsearchDirectHttpHandler",
"RolloutIdFilter",
"setup_rollout_logging_for_elasticsearch_handler",
Expand Down
6 changes: 3 additions & 3 deletions eval_protocol/pytest/remote_rollout_processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ def __init__(
poll_interval: float = 1.0,
timeout_seconds: float = 120.0,
output_data_loader: Optional[Callable[[DataLoaderConfig], DynamicDataLoader]] = None,
disable_elastic_search: bool = False,
disable_elastic_search_setup: bool = False,
elastic_search_config: Optional[ElasticsearchConfig] = None,
):
# Prefer constructor-provided configuration. These can be overridden via
Expand All @@ -108,11 +108,11 @@ def __init__(
self._poll_interval = poll_interval
self._timeout_seconds = timeout_seconds
self._output_data_loader = output_data_loader or _default_output_data_loader
self._disable_elastic_search = disable_elastic_search
self._disable_elastic_search_setup = disable_elastic_search_setup
self._elastic_search_config = elastic_search_config

def setup(self) -> None:
if self._disable_elastic_search:
if self._disable_elastic_search_setup:
logger.info("Elasticsearch is disabled, skipping setup")
return
logger.info("Setting up Elasticsearch")
Expand Down
Loading