ElasticSearch logging in RemoteRolloutProcessor (part 2)#242
Merged
Conversation
added 11 commits
October 1, 2025 12:57
- Updated _has_correct_timestamp_mapping method to check for rollout_id as a keyword field in Elasticsearch mappings. - Added rollout_id fixture to tests for setting up environment variable during test execution. - Modified test functions to include rollout_id in log messages and assertions, ensuring proper indexing and retrieval from Elasticsearch. - Implemented new tests to verify the presence and correctness of rollout_id in logged messages.
…ll__ exports for better accessibility.
- Added a method to extract status information from log records in ElasticSearchDirectHttpHandler. - Updated the data structure sent to Elasticsearch to include status_code, status_message, and status_details if present. - Modified ElasticsearchIndexManager to validate the mapping of new status fields. - Implemented tests to verify logging of status information and searching by status code in Elasticsearch.
- Replaced direct HTTP requests with an ElasticsearchClient for handling interactions with Elasticsearch in ElasticSearchDirectHttpHandler and ElasticsearchIndexManager. - Updated configuration handling to encapsulate Elasticsearch settings within a single config object. - Simplified index management and document indexing processes, improving code maintainability and readability. - Adjusted tests to utilize the new client for searching and verifying log entries, enhancing test reliability.
- Updated Elasticsearch integration to use ElasticSearchConfig from the types module, improving consistency across the codebase. - Removed the local ElasticsearchConfig dataclass in favor of the new model, streamlining configuration management. - Adjusted related classes and tests to utilize the updated configuration structure, enhancing maintainability and readability.
- Updated all instances of ElasticSearchConfig to ElasticsearchConfig across the codebase to align with official naming conventions. - Ensured that related classes and methods reflect this change, enhancing code clarity and maintainability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rollout_idhandling to ElasticSearchDirectHttpHandlerremote_server.pyto use newtracing.fireworks.aiproxy