ElasticSearch logging in RemoteRolloutProcessor (part 1)#240
Merged
Conversation
added 7 commits
September 30, 2025 16:10
- Introduced setup method in RemoteRolloutProcessor to initialize Elasticsearch if not disabled. - Added ElasticSearchConfig model for managing Elasticsearch configuration. - Implemented logic to parse environment variables from a .env file and start Elasticsearch if necessary. - Updated evaluation_test to call rollout_processor.setup() for proper initialization. - Modified RolloutProcessor to include a setup method for potential overrides in subclasses.
- Removed the previous logic for parsing environment variables and starting Elasticsearch directly. - Introduced a dedicated ElasticsearchSetup module to handle Elasticsearch initialization. - Updated the _setup_elastic_search method to utilize the new setup module for improved clarity and maintainability.
- Renamed and updated methods for clarity: _setup_local_elasticsearch to _setup_existing_docker_elasticsearch and _setup_remote_elasticsearch to _setup_initialized_docker_elasticsearch. - Improved comments to better describe the purpose of each setup method. - Enhanced the logic for initializing Elasticsearch with Docker, ensuring clearer handling of existing and new setups.
- Introduced a new attribute 'pid' to langfuse_row to facilitate detection of stopped evaluations. - Updated comments to clarify the purpose of the new attribute in relation to logging status updates.
- Introduced ElasticsearchDirectHttpHandler for asynchronous logging to Elasticsearch. - Added ElasticsearchIndexManager for managing index creation and mapping configuration. - Updated ElasticsearchSetup to create logging indices with proper mappings. - Enhanced ElasticSearchConfig model to include index_name attribute. - Implemented tests for ElasticsearchDirectHttpHandler to verify log transmission and sorting.
dphuang2
changed the title
dphuang2
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.