Support setting custom eval result output dir#238
Merged
Conversation
benjibc
approved these changes
Sep 30, 2025
benjibc
approved these changes
Sep 30, 2025
| if config.getoption("--ep-no-persist-results-jsonl"): | ||
| # flag to turn off persisting results as jsonl files | ||
| os.environ["EP_NO_PERSIST_RESULTS_JSONL"] = "1" | ||
|
|
Contributor
There was a problem hiding this comment.
can you ask chatgpt to come up with a better name? --ep-no-persist-results-jsonl just sounds so weird.
dphuang2
reviewed
Sep 30, 2025
Comment on lines
+84
to
+88
| should_upload = os.getenv("EP_NO_UPLOAD") != "1" | ||
|
|
||
| if should_upload: | ||
|
|
||
| def get_auth_value(key: str) -> str | None: |
Collaborator
There was a problem hiding this comment.
nit: this is a huge diff and added indentation
can you reverse condition and return early instead (e.g. if not should_upload: return)
mayinghan
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add
--ep-output-dirto support persist the eval result in jsonl format (by experiment) in a custom dir. previously they are saved in .eval_protocol folder under site-package/eval_protocol