RemoteRolloutProcessor / evaluation_test improvements#237
Merged
Conversation
Collaborator
dphuang2
commented
Sep 29, 2025
dphuang2
commented
- add row_ids for filtering
- set rollout status to error if timed out
- add status filed to StatusResponse model for remote server to propagate errors
added 4 commits
September 29, 2025 16:29
…ations - Introduced row_ids as an optional parameter to allow filtering of evaluation rows based on specified identifiers. - Updated documentation to reflect the new parameter and its usage in the evaluation process.
- Added logic to set the rollout status to an error when the polling loop completes without a successful break, indicating a timeout. - Enhanced error handling to provide clearer feedback on rollout timeouts.
…rocessor - Introduced an optional status indicator in the StatusResponse model to differentiate between successful and failed rollouts. - Updated documentation to clarify the purpose of the new status field for better understanding in the eval-protocol context.
…ion for clarity - Updated the parameter name from row_ids to filtered_row_ids to better reflect its purpose in filtering evaluation rows. - Adjusted related documentation to ensure consistency and clarity regarding the new parameter name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.