Skip to content

Merge dataset_info dictionaries and preserve ground_truth in RRP #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dphuang2 merged 1 commit into from
Sep 29, 2025
+9 −0
Merged

Merge dataset_info dictionaries and preserve ground_truth in RRP #235

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions eval_protocol/pytest/remote_rollout_processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,16 @@ def _load_data():
elif len(output_rows) == 1: # Return the Langfuse row
langfuse_row = output_rows[0]
langfuse_row.input_metadata.completion_params = row.input_metadata.completion_params
# merge dataset_info dicts on input_metadata
if langfuse_row.input_metadata.dataset_info and row.input_metadata.dataset_info:
langfuse_row.input_metadata.dataset_info = {
**row.input_metadata.dataset_info,
**langfuse_row.input_metadata.dataset_info,
}
elif row.input_metadata.dataset_info:
langfuse_row.input_metadata.dataset_info = row.input_metadata.dataset_info
langfuse_row.eval_metadata = row.eval_metadata
langfuse_row.ground_truth = row.ground_truth
return langfuse_row
else:
raise ValueError("RemoteRolloutProcessor's output_data_loader should return exactly one row.")
Expand Down
Loading