Conversation
benjibc
approved these changes
Sep 27, 2025
Comment on lines
+198
to
+203
| # dataloader might be overridden here, to avoid conflict, manually unset other data input params | ||
| if data_loaders: | ||
| input_dataset = None | ||
| input_messages = None | ||
| input_rows = None | ||
|
|
Contributor
There was a problem hiding this comment.
probably throwing an exception is better
Collaborator
Author
There was a problem hiding this comment.
data_loader could be set by "--ep-jsonl-path" extra flag here, i think we should just ignore user's original passed in stuff instead of throw an exception? if throw error here, user need to change their code to use the override flag then
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add runtime override option for several evaluator input params:
--ep-input-paramafter this, the parameter merging is very confusing and hard to get right.EP_REMOTE_ROLLOUT_PROCESSOR_BASE_URL. this config is very specific to one type of rollout processor, so didnt make it as a flag in pytest plugin.