Merged
Conversation
added 2 commits
September 19, 2025 14:11
added 6 commits
September 23, 2025 16:52
dphuang2
commented
Sep 24, 2025
Comment on lines
-24
to
-34
| try: | ||
| from langsmith import Client # type: ignore | ||
|
|
||
| LANGSMITH_CLIENT: Optional[Client] | ||
| try: | ||
| LANGSMITH_CLIENT = Client() | ||
| except Exception as exc: # pragma: no cover - surfaced to the caller | ||
| print(f"⚠️ LangSmith client unavailable: {exc}") | ||
| LANGSMITH_CLIENT = None | ||
| except ImportError: # pragma: no cover - optional dependency | ||
| LANGSMITH_CLIENT = None |
Collaborator
Author
There was a problem hiding this comment.
this was causing a warning message in pytest collection so i moved it into the test itself
dphuang2
commented
Sep 24, 2025
Comment on lines
-8
to
+15
| # Get API key using the new auth module | ||
| api_key = get_fireworks_api_key() | ||
| if api_key: | ||
| print(f"API key retrieved via auth module: {api_key[:4]}...{api_key[-4:]}") | ||
| else: | ||
| print("No API key retrieved via auth module.") | ||
|
|
||
| # Get account ID using the new auth module | ||
| account_id = get_fireworks_account_id() | ||
| if account_id: | ||
| print(f"Account ID retrieved via auth module: {account_id}") | ||
| else: | ||
| print("No account ID retrieved via auth module.") | ||
| def test_fireworks_api(): | ||
| # Get API key using the new auth module | ||
| api_key = get_fireworks_api_key() | ||
| if api_key: | ||
| print(f"API key retrieved via auth module: {api_key[:4]}...{api_key[-4:]}") | ||
| else: | ||
| print("No API key retrieved via auth module.") |
Collaborator
Author
There was a problem hiding this comment.
moved all of this test under an actual pytest test because this was causing error messages in pytest collection
dphuang2
commented
Sep 24, 2025
| self.filter = kwargs.get("filter", None) | ||
|
|
||
|
|
||
| @pytest.mark.integration |
Collaborator
Author
There was a problem hiding this comment.
non-existent markers warnings
xzrderek
reviewed
Sep 24, 2025
| # ] | ||
| input_rows = [] | ||
|
|
||
| # uncomment when dataloader is fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I went with a simpler/DRYer design that works with are adapters today. At its core this PR introduces
DynamicDataLoaderandInlineDataLoader. You useInlineDataLoaderfor hard-coded/static input rows. You useDynamicDataLoaderfor all the tracing adapters.