Draft
Conversation
dphuang2
reviewed
Sep 18, 2025
dphuang2
reviewed
Sep 18, 2025
Collaborator
dphuang2
left a comment
dphuang2
left a comment
There was a problem hiding this comment.
why not just accept a lambda that produces Sequence[list[EvaluationRow]]
dphuang2
reviewed
Sep 18, 2025
| completion_params=[{"model": "no-op"}], | ||
| rollout_processor=NoOpRolloutProcessor(), | ||
| max_dataset_rows=1, | ||
| preprocess_fn=_preprocess_rows, |
Collaborator
There was a problem hiding this comment.
shouldn't preprocessing happen in dataloader
dphuang2
reviewed
Sep 18, 2025
Comment on lines
+273
to
+279
| combinations: list[CombinationTuple] = [] | ||
| if has_data_loader_variants: | ||
| pytest_parametrize_args = _build_data_loader_parametrize_args( | ||
| loader_variants, | ||
| completion_params, | ||
| evaluation_test_kwargs, | ||
| ) |
Collaborator
There was a problem hiding this comment.
I don't think this should be its own conditional branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Current problems
Testing
https://chatgpt.com/codex/tasks/task_e_68cb974079d883338a38bb3b9c8e6fcb