Closed
Conversation
dphuang2
commented
Sep 17, 2025
Collaborator
Author
dphuang2
left a comment
dphuang2
left a comment
There was a problem hiding this comment.
mostly AI generated but will preserve invocation, experiment, run, row, and rollout ids somewere in this flow. But this is a high-level proposal to use pytest fixtures to parametrize the evals while still writing standalone evaluators as we already do.
benjibc
reviewed
Sep 17, 2025
| return request.param | ||
|
|
||
| # Pointwise fixture - parametrized across BOTH completion params AND dataset rows | ||
| @pytest.fixture(params=range(len(MATH_DATASET))) |
Contributor
There was a problem hiding this comment.
I don't get this line, this would come back as a list of int right?
Collaborator
Author
There was a problem hiding this comment.
yeah, this should probably be a list of row ids
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.