Merged
Conversation
xzrderek
approved these changes
Sep 15, 2025
dphuang2
reviewed
Sep 15, 2025
dphuang2
reviewed
Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds first-class LangSmith integration for seeding traces and evaluating LangGraph apps, plus a hardened adapter with tests.
Highlights
New adapter:
eval_protocol/adapters/langsmith.pyEvaluationRows.outputs.messages(when present) to avoid duplicated prompts.messages,prompt,user_input,input, raw string/listmessages,content,result,answer,output, raw string/listtool_calls,tool_call_id,function_call).tool_callsinto OpenAI-typedChatCompletionMessageToolCall/Function objects.Quickstart using LangSmith:
eval_protocol/quickstart/llm_judge_langsmith.pyquickstart/llm_judge.py(Langfuse), but usesLangSmithAdapter.SingleTurnRolloutProcessor+split_multi_turn_rows+ Arena-style LLM judge (Gemini/OpenAI).Bootstrap scripts (non-production, seeding only):
examples/langsmith/README.md: clarifies these scripts only dump traces for adapter/quickstart.dump_traces_langsmith.py: emits synthetic@traceableruns and tiny echo LangGraph runs.emit_tool_calls.py: emits traces with assistanttool_callsand a tool response.How to validate locally
export FIREWORKS_API_KEY=... pytest examples/langgraph/test_tools_langsmith_trace.py -q -s