Merged
Conversation
Co-authored-by: bchen <bchen@fireworks.ai>
|
Cursor Agent can help with this pull request. Just |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
name: Pull Request
about: Propose changes to the codebase
title: "Fix: Resolve initial type errors identified by pre-commit"
labels: ''
assignees: ''
Description
This PR addresses and resolves the first batch of type errors identified by
make precommit. The primary motivation is to improve code quality and maintainability by ensuring type consistency.Key changes include:
eval_protocol/agent/task_manager.py:resulttoDict[str, Any]before dictionary updates to ensure type compatibility.output_filehandling to consistently passPathobjects.eval_protocol/execution/pipeline.py:_process_single_sample_internalalways returns aDict[str, Any], including structured error dictionaries instead ofNone.user_querytostrwhere required for type correctness.self.cache.getcall.assistant_msg_for_historyasDict[str, Any]to allow non-string values like tool call lists.Fixes # (issue)
Implements # (issue)
Type of change
How Has This Been Tested?
The changes were verified by running
make precommitlocally after applying the fixes.make precommitTest Configuration:
Checklist:
black .,isort .,flake8 .)Screenshots (if applicable)
N/A
Additional context
This PR addresses the initial set of type errors. Further type errors may exist in other parts of the codebase, particularly in tests and other modules, related to optional-member access, incorrect argument types, and list invariance.