preserve metadata and evaluator id etc to the wrapped eval func#108
Merged
preserve metadata and evaluator id etc to the wrapped eval func#108
Conversation
dphuang2
reviewed
Aug 20, 2025
Collaborator
dphuang2
left a comment
dphuang2
left a comment
There was a problem hiding this comment.
- can you move any computation logic of the ID into a utility function. evaluation_test is getting too complex.
- what happens if dependencies change? Should you also use the
get_pep440_versionfunction as input to your id? Its not perfect, but it will ensure a new ID is created if new commits are made to the codebase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.