-
Notifications
You must be signed in to change notification settings - Fork 12
page visualization modification #311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: publish
Are you sure you want to change the base?
Conversation
|
|
Hi @jdries Follow-up on #270 Also, at the moment, the collection files are generated on-fly, and it stays there, so I am not sure if there could be better ways. However, before I continue further, could you please share your feedback and suggestions on whether this visualisation solution could be an option? Furthermore, I think it's important to address PR1, PR2, or any relevant PRs to prevent merge conflicts, as these changes will involve rearranging the files. |
|
For me this already looks like a good improvement over the previous approach, as we fit more info in a single view. Of course, UX experts like @JanssenBrm or @soxofaan may also have some thoughts? |
Yes, ordering the tiles was possible; I tried based on time/alphabet but didn't implement it here. It is now based on file naming. However, more might be possible.
No, if we figure out what to change in cards/listing, it was only a few lines at the top since all text comes from metadata so easily manageable. The only tricky now is figuring out some of these issues with rendering. |
Looks indeed better. Not much to add at this point. Maybe adding the thumbnail image when available? |
I agree and actually, with a default setting the first image appears as a thumbnail, so it should be possible to modify(at the moment the icon comes up as image) |
|
If everyone agrees @jdries @soxofaan @JanssenBrm , I would suggest first finalizing the actions for existing data-related PRs(either merge or close) esp #270 and #216, since they can create merge conflict later.
|
| import sys | ||
| import os | ||
| sys.path.append('..') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sys.path.append('..') looks strange to me: you want to be able to import custom files outside of the repository?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, I tried some other ways, too, but since it was being rendered and function files were in different locations, it caused an issue. Maybe rearranging in order for these function files might also be needed and should be taken into consideration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sys.path.append('..') is a brittle solution as it assumes that you are working from a certain directory. I guess there must be some quarto config to just specify addtional paths to search for dependencies you want to import, but I don't know quarto well enough to figure that out at the moment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I can look into this aspect; there might be a way within Quarto.
|
Is this PR still relevant? I see there are a lot of conflicts with main branch, so maybe it's best to start over. In any case I'm going to remove the pr-preview build for this PR in the context of #633 |
Testing for better visualization and management of pages as a possible solution to increasing data collections.