Skip to content

Merge TASK-018: http_request single-key getters return string_view, a…

57717ea
Select commit
Loading
Failed to load commit list.
Draft

v2.0: Modernization (M1-M6, 44 tasks) #374

Merge TASK-018: http_request single-key getters return string_view, a…
57717ea
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded May 6, 2026 in 1s

69.51% (+1.48%) compared to d8b055e

View this Pull Request on Codecov

69.51% (+1.48%) compared to d8b055e

Details

Codecov Report

❌ Patch coverage is 75.52632% with 186 lines in your changes missing coverage. Please review.
✅ Project coverage is 69.51%. Comparing base (d8b055e) to head (57717ea).
⚠️ Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/http_request.cpp 66.85% 47 Missing and 73 partials ⚠️
src/http_response.cpp 82.31% 1 Missing and 28 partials ⚠️
src/create_test_request.cpp 48.00% 0 Missing and 13 partials ⚠️
src/detail/body.cpp 89.06% 1 Missing and 6 partials ⚠️
src/httpserver/feature_unavailable.hpp 40.00% 0 Missing and 6 partials ⚠️
src/httpserver/detail/http_request_impl.hpp 75.00% 3 Missing and 2 partials ⚠️
src/httpserver/detail/body.hpp 93.47% 2 Missing and 1 partial ⚠️
src/httpserver/http_method.hpp 93.75% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #374      +/-   ##
==========================================
+ Coverage   68.03%   69.51%   +1.48%     
==========================================
  Files          34       26       -8     
  Lines        1730     2244     +514     
  Branches      697      821     +124     
==========================================
+ Hits         1177     1560     +383     
- Misses         80      140      +60     
- Partials      473      544      +71     
Files with missing lines Coverage Δ
src/detail/http_endpoint.cpp 60.00% <ø> (ø)
src/http_resource.cpp 25.00% <100.00%> (+8.33%) ⬆️
src/http_utils.cpp 66.97% <100.00%> (ø)
src/httpserver/create_webserver.hpp 96.98% <ø> (ø)
src/httpserver/detail/http_endpoint.hpp 85.00% <ø> (ø)
src/httpserver/detail/modded_request.hpp 100.00% <ø> (ø)
src/httpserver/detail/webserver_impl.hpp 100.00% <100.00%> (ø)
src/httpserver/file_info.hpp 100.00% <ø> (ø)
src/httpserver/http_request.hpp 91.30% <100.00%> (+2.93%) ⬆️
src/httpserver/http_resource.hpp 85.10% <100.00%> (ø)
... and 11 more

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8b055e...57717ea. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.