-
Notifications
You must be signed in to change notification settings - Fork 85
move task status sets to a classmethod #7170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (88.88%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #7170 +/- ##
==========================================
- Coverage 87.17% 87.17% -0.01%
==========================================
Files 534 534
Lines 35312 35317 +5
Branches 4113 4113
==========================================
+ Hits 30783 30787 +4
- Misses 3638 3639 +1
Partials 891 891 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Greptile SummaryRefactored task status constants from module-level lists to classmethods on Key Changes:
Notes:
Confidence Score: 5/5
Important Files Changed
|
Greptile's behavior is changing!From now on, if a review finishes with no comments, we will not post an additional "statistics" comment to confirm that our review found nothing to comment on. However, you can confirm that we reviewed your changes in the status check section. This feature can be toggled off in your Code Review Settings by deselecting "Create a status check for each PR". |
Description Of Changes
Some cleanup/code org improvement as discussed in https://github.com/ethyca/fidesplus/pull/2888#discussion_r2593483866
Code Changes
ExecutionLogStatusesSteps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works