Skip to content

Conversation

@adamsachs
Copy link
Contributor

@adamsachs adamsachs commented Dec 22, 2025

Description Of Changes

Some cleanup/code org improvement as discussed in https://github.com/ethyca/fidesplus/pull/2888#discussion_r2593483866

Code Changes

  • some classmethods to define relevant sets of ExecutionLogStatuses

Steps to Confirm

  1. CI passing should be sufficient
  2. https://github.com/ethyca/fidesplus/pull/2884 has some associated fidesplus adjustments

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link

vercel bot commented Dec 22, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Review Updated (UTC)
fides-plus-nightly Ignored Ignored Dec 22, 2025 4:16pm
fides-privacy-center Ignored Ignored Dec 22, 2025 4:16pm

@codecov
Copy link

codecov bot commented Dec 22, 2025

Codecov Report

❌ Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 87.17%. Comparing base (95efd69) to head (2dcb64a).
⚠️ Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/fides/api/models/worker_task.py 85.71% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (88.88%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7170      +/-   ##
==========================================
- Coverage   87.17%   87.17%   -0.01%     
==========================================
  Files         534      534              
  Lines       35312    35317       +5     
  Branches     4113     4113              
==========================================
+ Hits        30783    30787       +4     
- Misses       3638     3639       +1     
  Partials      891      891              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@adamsachs adamsachs marked this pull request as ready for review December 22, 2025 18:11
@adamsachs adamsachs requested a review from a team as a code owner December 22, 2025 18:11
@adamsachs adamsachs requested review from erosselli and johnewart and removed request for a team and johnewart December 22, 2025 18:11
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 22, 2025

Greptile Summary

Refactored task status constants from module-level lists to classmethods on ExecutionLogStatus enum for better code organization.

Key Changes:

  • Converted RESUMABLE_EXECUTION_LOG_STATUSES module constant to ExecutionLogStatus.resumable_statuses() classmethod
  • Added ExecutionLogStatus.in_progress_statuses() classmethod (currently unused but prepared for future use)
  • Changed return type from List to Set for more appropriate semantics
  • Updated single usage in execute_request_tasks.py:178 to call the new method

Notes:

  • Both methods include TODO comments indicating they're currently specific to certain task types (DSR tasks, monitor tasks) but may become more generic in the future
  • in_progress_statuses() is defined but not yet used anywhere in the codebase

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • Simple refactoring that moves module-level constants to classmethods. The change improves code organization without altering behavior. All usages updated correctly, and the change is well-scoped.
  • No files require special attention

Important Files Changed

Filename Overview
src/fides/api/models/worker_task.py Refactored status constants to classmethods - adds Set import, converts module-level list constant to two classmethod accessors returning sets
src/fides/api/task/execute_request_tasks.py Updated to use new resumable_statuses() classmethod instead of RESUMABLE_EXECUTION_LOG_STATUSES constant

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 22, 2025

Greptile's behavior is changing!

From now on, if a review finishes with no comments, we will not post an additional "statistics" comment to confirm that our review found nothing to comment on. However, you can confirm that we reviewed your changes in the status check section.

This feature can be toggled off in your Code Review Settings by deselecting "Create a status check for each PR".

@adamsachs adamsachs added this pull request to the merge queue Dec 23, 2025
Merged via the queue into main with commit 422cc78 Dec 23, 2025
70 of 71 checks passed
@adamsachs adamsachs deleted the asachs/execution-log-tweak branch December 23, 2025 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants