Add OpenTelemetry and basic tracing + dev infra#7163
Open
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Contributor
Greptile SummaryThis PR adds OpenTelemetry distributed tracing support to Fides, including:
Key Issues Found:
Confidence Score: 3/5
Important Files Changed
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
| # OpenTelemetry imports are optional - app should work without them | ||
| try: | ||
| from opentelemetry import trace | ||
| from opentelemetry.exporter.otlp.proto.grpc.trace_exporter import OTLPSpanExporter |
Contributor
There was a problem hiding this comment.
style: Unused import - OTLPSpanExporter is imported here but local imports are used inside _create_otlp_exporter instead.
| ConsoleSpanExporter, | ||
| SpanExporter, | ||
| ) | ||
| from opentelemetry.sdk.trace.sampling import ParentBasedTraceIdRatio |
Contributor
There was a problem hiding this comment.
style: Unused import - ParentBasedTraceIdRatio is imported but never used (commented-out code on line 110).
| # Determine if we're using gRPC or HTTP based on the endpoint | ||
| endpoint = config.tracing.otlp_endpoint | ||
| protocol = config.tracing.otlp_protocol | ||
| exporter = config.tracing.otlp_exporter |
Contributor
There was a problem hiding this comment.
style: exporter variable is assigned but never used.
Remove temporary increased sample rate Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Moved grafana to port 3010 to not conflict with fides-ui Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7163 +/- ##
==========================================
- Coverage 87.17% 85.49% -1.69%
==========================================
Files 534 536 +2
Lines 35312 35515 +203
Branches 4113 4142 +29
==========================================
- Hits 30783 30362 -421
- Misses 3638 4221 +583
- Partials 891 932 +41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
galvana
requested changes
Jan 12, 2026
Contributor
There was a problem hiding this comment.
We're missing the Prometheus dependencies
prometheus-client==0.19.0
prometheus-fastapi-instrumentator==6.1.0
| ) | ||
|
|
||
| fastapi_app = FastAPI(title="fides", version=app_version, lifespan=lifespan, separate_input_output_schemas=False) # type: ignore | ||
| Instrumentator().instrument(fastapi_app).expose(fastapi_app, endpoint="/metrics") |
Contributor
There was a problem hiding this comment.
We should remove this from the Swagger docs since this is just for Prometheus and not meant to be human-readable.
Suggested change
| Instrumentator().instrument(fastapi_app).expose(fastapi_app, endpoint="/metrics") | |
| Instrumentator().instrument(fastapi_app).expose(fastapi_app, endpoint="/metrics", include_in_schema=False) |
| workers_enabled=False, workers=[], queue_counts={} | ||
| ).model_dump(mode="json") | ||
|
|
||
| with add_span_event("workers_health_check"): |
Contributor
There was a problem hiding this comment.
add_span_event isn't a context manager, should this be trace_span?
Suggested change
| with add_span_event("workers_health_check"): | |
| with trace_span("workers_health_check"): |
| @@ -0,0 +1,2 @@ | |||
| #!/bin/env sh | |||
| influx bucket create -n k6_tests -o ethyca -r 120d No newline at end of file | |||
Comment on lines
+35
to
+38
| otlp_exporter: Optional[str] = Field( | ||
| default="otlp", | ||
| description="OTLP exporter to use for exporting traces (otlp or console).", | ||
| ) |
Contributor
There was a problem hiding this comment.
Is this used anywhere?
Suggested change
| otlp_exporter: Optional[str] = Field( | |
| default="otlp", | |
| description="OTLP exporter to use for exporting traces (otlp or console).", | |
| ) |
Comment on lines
+30
to
+33
| otlp_protocol: Optional[str] = Field( | ||
| default="http/protobuf", | ||
| description="OTLP protocol to use for exporting traces (http/protobuf or grpc).", | ||
| ) |
Contributor
There was a problem hiding this comment.
Suggested change
| otlp_protocol: Optional[str] = Field( | |
| default="http/protobuf", | |
| description="OTLP protocol to use for exporting traces (http/protobuf or grpc).", | |
| ) | |
| otlp_protocol: Literal["http/protobuf", "grpc"] = Field( | |
| default="http/protobuf", | |
| description="OTLP protocol to use for exporting traces.", | |
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Open Telemetry along with basic tracing of FastAPI, httpx and sqlalchemy, a convenience tracing module to start new spans, and also adds the following to
nox -s dev: Prometheus (for scraping metrics later), tempo (for collecting OTel traces), memcached (for tempo), and grafana (to view metrics/traces). When your dev setup is running, you can hithttp://localhost:3000and see Grafana. On the left is 'Drilldown > Traces' which will take you to the traces view; down at the bottom is a traces tab that will show you all the traces for the service.