Custom Alpha Image - Resurface Banner on Reject - v2#7120
Closed
jjdaurora wants to merge 1 commit intorelease-2.76.1from
Closed
Custom Alpha Image - Resurface Banner on Reject - v2#7120jjdaurora wants to merge 1 commit intorelease-2.76.1from
jjdaurora wants to merge 1 commit intorelease-2.76.1from
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
Contributor
Greptile OverviewGreptile SummaryThis PR modifies the
Confidence Score: 4/5
Important Files ChangedFile Analysis
|
Contributor
There was a problem hiding this comment.
Additional Comments (1)
-
clients/fides-js/__tests__/lib/consent-utils.test.ts, line 340 (link)style: Test label says "returns false" but the expected value is now
true. Update the label to match the new behavior.
2 files reviewed, 2 comments
Comment on lines
345
to
+348
| }, | ||
| savedConsent: mockSavedConsent, | ||
| options: {}, | ||
| expected: false, | ||
| expected: true, |
Contributor
There was a problem hiding this comment.
style: Consider adding a test case for ConsentMethod.REJECT in TCF experiences to ensure both DISMISS and REJECT behaviors are covered by tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket [ENG-2224]
Description Of Changes
Custom alpha image for client. Includes updates in 2.76.1 plus Banner Resurfacing.
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works