Skip to content

draft: switch taxonomy and dataset endpoints to be non-async #6764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
adamsachs wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

draft: switch taxonomy and dataset endpoints to be non-async #6764

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8497987
switch non async endpoints to be non async
adamsachs Oct 15, 2025
1678422
Merge branch 'main' into asachs/change-taxonomy-endpoints-sync
adamsachs Dec 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions src/fides/api/api/v1/endpoints/generic_overrides.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@
status_code=status.HTTP_201_CREATED,
name="Create dataset",
)
async def create_dataset(
def create_dataset(
dataset: FideslangDataset,
dataset_service: DatasetService = Depends(get_dataset_service),
) -> Dict:
Expand Down Expand Up @@ -108,7 +108,7 @@ async def create_dataset(
status_code=status.HTTP_200_OK,
name="Update dataset",
)
async def update_dataset(
def update_dataset(
dataset: FideslangDataset,
dataset_service: DatasetService = Depends(get_dataset_service),
) -> Dict:
Expand Down Expand Up @@ -239,7 +239,7 @@ async def list_dataset_paginated(
response_model=FideslangDataset,
name="Get dataset",
)
async def get_dataset(
def get_dataset(
fides_key: str,
dataset_service: DatasetService = Depends(get_dataset_service),
) -> Dict:
Expand All @@ -258,7 +258,7 @@ async def get_dataset(
dependencies=[Security(verify_oauth_client, scopes=[CTL_DATASET_DELETE])],
name="Delete dataset",
)
async def delete_dataset(
def delete_dataset(
fides_key: str,
dataset_service: DatasetService = Depends(get_dataset_service),
) -> JSONResponse:
Expand Down Expand Up @@ -294,7 +294,7 @@ async def delete_dataset(
)
],
)
async def upsert_datasets(
def upsert_datasets(
datasets: List[FideslangDataset],
response: Response,
dataset_service: DatasetService = Depends(get_dataset_service),
Expand Down Expand Up @@ -359,7 +359,7 @@ def clean_datasets(
status_code=status.HTTP_201_CREATED,
name="Create",
)
async def create_data_use(
def create_data_use(
data_use: DataUseCreateOrUpdate,
taxonomy_service: TaxonomyService = Depends(get_taxonomy_service),
) -> Dict:
Expand Down Expand Up @@ -389,7 +389,7 @@ async def create_data_use(
status_code=status.HTTP_201_CREATED,
name="Create",
)
async def create_data_category(
def create_data_category(
data_category: DataCategoryCreateOrUpdate,
taxonomy_service: TaxonomyService = Depends(get_taxonomy_service),
) -> Dict:
Expand Down Expand Up @@ -420,7 +420,7 @@ async def create_data_category(
status_code=status.HTTP_201_CREATED,
name="Create",
)
async def create_data_subject(
def create_data_subject(
data_subject: DataSubjectCreateOrUpdate,
taxonomy_service: TaxonomyService = Depends(get_taxonomy_service),
) -> Dict:
Expand Down Expand Up @@ -451,7 +451,7 @@ async def create_data_subject(
status_code=status.HTTP_200_OK,
name="Update",
)
async def update_data_use(
def update_data_use(
data_use: DataUseCreateOrUpdate,
taxonomy_service: TaxonomyService = Depends(get_taxonomy_service),
) -> Dict:
Expand Down Expand Up @@ -487,7 +487,7 @@ async def update_data_use(
status_code=status.HTTP_200_OK,
name="Update",
)
async def update_data_category(
def update_data_category(
data_category: DataCategoryCreateOrUpdate,
taxonomy_service: TaxonomyService = Depends(get_taxonomy_service),
) -> Dict:
Expand Down
Loading