feat(kafka): implement SCRAM-SHA-256/512 authentication support#724
Open
jpedrosa94 wants to merge 1 commit intoethpandaops:masterfrom
Open
feat(kafka): implement SCRAM-SHA-256/512 authentication support#724jpedrosa94 wants to merge 1 commit intoethpandaops:masterfrom
jpedrosa94 wants to merge 1 commit intoethpandaops:masterfrom
Conversation
- Add scramClient implementation for SASL SCRAM authentication - Set SCRAMClientGeneratorFunc for SCRAM-SHA-256 and SCRAM-SHA-512 - Add xdg-go/scram dependency for SCRAM protocol handling - Fix incomplete SCRAM support that only accepted config but didn't implement protocol - Add documentation for SASL authentication in sentry, cannon, and mimicry docs - Add SCRAM-SHA-512 configuration examples
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes incomplete SCRAM authentication implementation in Kafka output. The code accepted SCRAM configuration but didn't implement the actual SCRAM protocol handler, causing authentication failures.
Changes
scramClientimplementation for SASL SCRAM authenticationSCRAMClientGeneratorFuncfor SCRAM-SHA-256 and SCRAM-SHA-512 mechanismsxdg-go/scramdependency for SCRAM protocol handlingTesting
juliopedrosa/xatu:scram-fix) to our environment for validationBackground
We needed SCRAM authentication for our Kafka infrastructure and discovered the existing implementation was incomplete. Created a forked Docker image with this fix that we're currently running in our environment.
Related Issues
Fixes issue where Kafka output with SCRAM mechanisms would fail to authenticate despite correct configuration. #726