feat: EASY_PROXY_DOCKER_RUN_OPTS — extra docker run options (#32)#33
Merged
Conversation
`easy proxy create` ran a fixed `docker run` — there was no way to add extra options (extra published ports, resource limits, ...). Operators set EASY_PROXY_DOCKER_RUN_OPTS expecting it to be honoured, but the CLI never read it. `easy proxy create` now splices $EASY_PROXY_DOCKER_RUN_OPTS (word-split) into the `docker run`, before the image. Unset → behaviour unchanged. - commands/proxy.sh: create reads EASY_PROXY_DOCKER_RUN_OPTS - test/create.bats: 3 tests; test_helper unsets the var for isolation - CLAUDE.md, CHANGELOG.md updated `npm run lint` exits 0; the bats suite passes 52/52. Closes #32 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
easy proxy createran a fixeddocker run—--name, the volumes,-p 80:80 -p 443:443, the image. No way to add extra options: extra published ports (e.g.-p 8089:8089), resource limits, etc. Operators setEASY_PROXY_DOCKER_RUN_OPTSin their profile expecting it to be honoured — but the CLI never read it, so it was silently ignored.Fix
easy proxy createsplices$EASY_PROXY_DOCKER_RUN_OPTS(word-split) into thedocker run, before the image:Unset → behaviour unchanged.
Changes
commands/proxy.sh—createreadsEASY_PROXY_DOCKER_RUN_OPTSviaread -rainto an array spliced into thedocker run.test/create.bats— 3 tests (single opt, multiple opts, unset);test_helper.bashunsets the var for test isolation.CLAUDE.md,CHANGELOG.mdupdated.Test plan
TDD — tests written first, watched fail, then made green.
Closes #32
🤖 Generated with Claude Code