fix: issue #39#42
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #39.
This PR fixes precision drift in
relayer_getFeeData.ratewithout changing the API shape. Theratefield remains a numeric value in the response, but RelayX now computes it using exact scaled integer math and rounds it deterministically to 6 decimal places before serialization.Problem
relayer_getFeeDatawas derivingratefrom Chainlink-style oracle values usingf64arithmetic. That can introduce binary floating-point precision and rounding inconsistencies, especially when clients use the returned rate for fee calculations.What Changed
f64-based rate calculation insrc/methods/fee_data.rswith scaledU256integer math.relayer_getFeeData.rate.rateis still returned as a JSON numberFeeDataResponse.rateremainsf64Why This Approach
The issue is not that
rateis a number on the wire. The issue is that the number was previously derived using floating-point math.This change preserves backward compatibility for clients while making the returned value deterministic and easier to reason about.
Testing
cargo test --libNotes
rate: 1.0.relayer_getQuoteis intentionally not changed in this PR; this fix is scoped torelayer_getFeeData/relayer_getExchangeRate.