Skip to content

feat: fix arka backend docker #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sankhavaramsaitulasiram merged 1 commit into from
Dec 11, 2025
Merged

feat: fix arka backend docker #233

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions backend/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ ARG APP_ENV
WORKDIR /app
COPY . .
COPY --from=deps /app/node_modules ./node_modules
RUN cp config.json.default config.json
RUN bun run build
Comment on lines +12 to 13
Copy link

@coderabbitai coderabbitai bot Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial

Consider adding error handling or a clarifying comment.

The copy operation on line 12 has no fallback if config.json.default is missing, and the intent (that bun run build requires config.json to exist) is not documented. This would aid maintainability and debugging.

Apply this diff to add a clarifying comment and defensive fallback:

-RUN cp config.json.default config.json
+# Ensure config.json exists for the build process
+RUN cp config.json.default config.json || (echo "{}" > config.json && echo "Warning: using empty config" >&2)

Alternatively, if the fallback is unnecessary (because config.json.default is always present), simply add a comment:

-RUN cp config.json.default config.json
+# Create config.json from default for the build step
+RUN cp config.json.default config.json
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
RUN cp config.json.default config.json
RUN bun run build
# Ensure config.json exists for the build process
RUN cp config.json.default config.json || (echo "{}" > config.json && echo "Warning: using empty config" >&2)
RUN bun run build
🧰 Tools
🪛 Hadolint (2.14.0)

[info] 13-13: Multiple consecutive RUN instructions. Consider consolidation.

(DL3059)

🤖 Prompt for AI Agents 
In backend/Dockerfile around lines 12 to 13, the RUN cp config.json.default
config.json step has no fallback or explanation and causes the build to fail if
config.json.default is missing; add a brief clarifying comment stating that bun
run build depends on config.json and either make the COPY step defensive (create
a default config.json when config.json.default is absent or copy from a known
path) or explicitly check for existence before copying so the build fails with a
clear message; if the default is guaranteed to exist, simply add a comment
documenting that invariant so future maintainers understand why the copy is
safe.


FROM oven/bun:1-alpine AS runner
Expand Down
Loading