fix:refactor sushi router#132
Merged
Merged
Conversation
Collaborator
0xCardiE
commented
Apr 8, 2026
0xCardiE
commented
- Replace stray require() with custom error in uniswapV3SwapCallback
- Eliminate two token0()/token1() external calls in callback (derive from path)
- Emit actual amountIn (not maxAmountIn) in all BatchCreated/ToppedUp events
- Add zero-address guard in constructor
- Trim IWXDAI and ISushiV3Pool interfaces to only used methods
- Replace byte-by-byte _skipToken loop with assembly mstore copy
…03a99de8B407A3237aaf54D1b779C - Replace stray require() with custom error in uniswapV3SwapCallback - Eliminate two token0()/token1() external calls in callback (derive from path) - Emit actual amountIn (not maxAmountIn) in all BatchCreated/ToppedUp events - Add zero-address guard in constructor - Trim IWXDAI and ISushiV3Pool interfaces to only used methods - Replace byte-by-byte _skipToken loop with assembly mstore copy - Update deployment artifacts and app constant to new address
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.