fix: remove unused kademlia check #555
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove the kademlia check which evaluates internal node data structures rather than hive behavior.
Rationale
Beekeeper is for testing hives
Beekeeper's purpose is to test the behavior of multiple swarm nodes working together as a hive. The kademlia check queries individual nodes'
/topologyendpoints and evaluates internal data structures (depth, bins, population). This does not test how nodes interact with each other as a swarm.Not used in CI
The kademlia check has never been included in bee's CI workflow. The actual CI checks used are:
ci-full-connectivity,ci-settlements,ci-pss,ci-soc,ci-gsoc,ci-pushsync-chunks,ci-pushsync-light-chunks,ci-retrieval,ci-manifest,ci-feed.Hive behavior is tested elsewhere
Actual hive connectivity and routing behavior is properly tested by:
fullconnectivity- verifies nodes can communicate via ping/pongpushsync/retrieval- verifies chunks route correctly through the swarmThese checks validate how nodes work together as a hive rather than internal implementation details of individual nodes.