Reference information for FA bridging calls and events#367
Open
timothymcmackin wants to merge 10 commits intomainfrom
Open
Reference information for FA bridging calls and events#367timothymcmackin wants to merge 10 commits intomainfrom
timothymcmackin wants to merge 10 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
timothymcmackin
changed the title
timothymcmackin
force-pushed
the
fa-bridge-events
branch
from
b8c15d8 to
3480309
Compare
timothymcmackin
force-pushed
the
fa-bridge-events
branch
from
2b2bec3 to
f73117f
Compare
timothymcmackin
force-pushed
the
fa-bridge-events
branch
from
780d2b1 to
4d205fc
Compare
timothymcmackin
force-pushed
the
fa-bridge-events
branch
from
4d205fc to
1f96ddc
Compare
timothymcmackin
force-pushed
the
fa-bridge-events
branch
from
11ad135 to
091c992
Compare
timothymcmackin
force-pushed
the
fa-bridge-events
branch
from
091c992 to
72f4eb3
Compare
Eitu33
reviewed
Jan 30, 2026
docs/bridging/bridging-fa-how.md
Outdated
| Field | Type | Description | ||
| --- | --- | --- | ||
| `ticketOwner` | address | The ERC-20 proxy contract that manages the tokens | ||
| `receiver` | address | The ERC-20 proxy contract that manages the tokens (a duplicate of the `ticketOwner` field) |
There was a problem hiding this comment.
This is untrue, it is the etherlink account receiving the FA deposit tokens
docs/bridging/bridging-fa-how.md
Outdated
| `sender` | address | The Etherlink address that is withdrawing the tokens | ||
| `ticketOwner` | address | The ERC-20 proxy contract that manages the tokens | ||
| `receiver` | bytes22 | The layer 1 address that receives the tokens | ||
| `proxy` | bytes22 | The proxy address through which the deposit is routed |
There was a problem hiding this comment.
This might confusing w.r.t. other proxy mentions in the doc, this a L1 contract, in previous events proxy refers to a L2 contract
Collaborator
Author
There was a problem hiding this comment.
Which contract is this, the token brige helper contract, the ticketer contract, or something else?
Collaborator
Author
There was a problem hiding this comment.
Based on discussion this appears to be the token bridge helper contract.
docs/bridging/bridging-fa-how.md
Outdated
|
|
||
| Field | Type | Description | ||
| --- | --- | --- | ||
| `ticketOwner` | address | The ERC-20 proxy contract that manages the tokens |
There was a problem hiding this comment.
ticketOwner can sometimes be the receiver, but imho this is an implem detail and shouldn't be mentionned, I'll let you be the judge of it
Collaborator
Author
There was a problem hiding this comment.
I'll add "or, in some cases, the account receiving the deposited tokens"
docs/bridging/bridging-fa-how.md
Outdated
| `sender` | address | The Etherlink address that is withdrawing the tokens | ||
| `ticketOwner` | address | The ERC-20 proxy contract that manages the tokens | ||
| `receiver` | bytes22 | The layer 1 address that receives the tokens | ||
| `proxy` | bytes22 | The proxy address through which the deposit is routed |
timothymcmackin
force-pushed
the
main
branch
3 times, most recently
from
bcee516 to
523b649
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provide more detailed information about how the FA bridge works. I took information about the events from
etherlink/kernel_latest/revm/contracts/fa_bridge.solbut I'm not sure if I've got each field explained clearly.