Skip to content

chore: minor improvement for docs #3781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
geogrego wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −3
Open

chore: minor improvement for docs #3781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions web3/_utils/contracts.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,8 @@ def prepare_transaction(
) -> TxParams:
"""
Returns a dictionary of the transaction that could be used to call this
function.

TODO: make this a public API
TODO: add new prepare_deploy_transaction API
"""
Expand Down
2 changes: 1 addition & 1 deletion web3/_utils/transactions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,7 @@ def prepare_replacement_transaction(
replacement_transaction["nonce"] != original_transaction["nonce"]
):
raise Web3ValueError(
"Supplied nonce in new_transaction must match the pending transaction"
"Supplied nonce in replacement_transaction must match the pending transaction"
)

if "nonce" not in replacement_transaction:
Expand Down
4 changes: 2 additions & 2 deletions web3/_utils/utility_methods.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ def either_set_is_a_subset(
Returns a bool based on whether two sets might have some differences but are mostly
the same. This can be useful when comparing formatters to an actual response for
formatting.

:param set1: A set of values.
:param set2: A second set of values.
:param percentage: The percentage of either set that must be present in the
Expand All @@ -79,4 +79,4 @@ def either_set_is_a_subset(
return (
len(set1.intersection(set2)) >= len(set1) * threshold
or len(set2.intersection(set1)) >= len(set2) * threshold
)
)