core/txpool/blobpool: remove legacy sidecar conversion #33352
+25
−880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjl493456442
requested review from
MariusVanDerWijden,
fjl,
jwasinger and
lightclient
as code owners
healthykim
reviewed
Dec 5, 2025
| // preCheck performs the static validation upon the provided tx. | ||
| // | ||
| // This function is pure static and lock free. | ||
| func (p *BlobPool) preCheck(tx *types.Transaction) error { |
Contributor
There was a problem hiding this comment.
Why do we want to keep this function? Inside of ValidateTransaction we are already checking whether we have entered osaka. Could we integrate it there or is there a specific reason to keep this function ??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the legacy sidecar conversion logic.
After the Osaka fork, the blobpool will accept only blob sidecar version 1.
Any remaining version 0 blob transactions, if they still exist, will no longer
be eligible for inclusion.
Note that conversion at the RPC layer is still supported, and version 0 blob
transactions will be automatically converted to version 1 there.