Skip to content

Follow-up: Treat ACDT recordings as non-livestreamed#301

Draft
dionysuzx wants to merge 1 commit into
ethereum:mainfrom
dionysuzx:acdt-recorded-sync-offsets
Draft

Follow-up: Treat ACDT recordings as non-livestreamed#301
dionysuzx wants to merge 1 commit into
ethereum:mainfrom
dionysuzx:acdt-recorded-sync-offsets

Conversation

@dionysuzx
Copy link
Copy Markdown
Collaborator

@dionysuzx dionysuzx commented May 31, 2026

Summary

Follow-up companion for after ACDT composed uploads are enabled in PM.

  • treats only ACDE and ACDC as manually livestreamed calls during PM asset sync
  • lets new ACDT call configs default transcript and video sync offsets to 00:00:00

Status

This should not merge while ACDT is still using the normal livestream path. Keep it as a follow-up for the activation PR.

Tests

  • node --check scripts/sync-call-assets.mjs
  • git diff --check

@netlify
Copy link
Copy Markdown

netlify Bot commented May 31, 2026

Deploy Preview for eth-forkcast ready!

Name Link
🔨 Latest commit a7a9b71
🔍 Latest deploy log https://app.netlify.com/projects/eth-forkcast/deploys/6a1c8260d176940008ca7bce
😎 Deploy Preview https://deploy-preview-301--eth-forkcast.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 86 (🟢 up 3 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@dionysuz-bot
Copy link
Copy Markdown

No blocking issues found.

Reviewed scripts/sync-call-assets.mjs; the change is scoped to newly generated configs and leaves existing ACDT configs untouched. I also verified:

  • node --check scripts/sync-call-assets.mjs
  • git diff --check HEAD^..HEAD

@dionysuzx dionysuzx marked this pull request as draft June 1, 2026 04:16
@dionysuzx dionysuzx changed the title Treat ACDT recordings as non-livestreamed Follow-up: Treat ACDT recordings as non-livestreamed Jun 1, 2026
@dionysuzx
Copy link
Copy Markdown
Collaborator Author

@dionysuz-bot please review

@dionysuz-bot
Copy link
Copy Markdown

Found one blocking merge condition:

  • scripts/sync-call-assets.mjs:77 makes every newly generated ACDT config default both sync offsets to 00:00:00. That is only correct after PM’s composed-upload path is active for ACDT. Current main still shows ACDT 81 was generated with null offsets and then manually fixed to non-zero offsets (00:06:09 / 00:04:02), so merging this before that activation would publish mis-synced future ACDT calls. Keep this draft/blocked until the PM activation lands, or gate the behavior on manifest/source metadata instead of only the series name.

No other blocking issues in the code shape. node --check scripts/sync-call-assets.mjs and git diff --check origin/main...HEAD pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants