feat(spec-specs, spec-tests): add EIP-7843 SLOTNUM opcode#2853
Open
kclowes wants to merge 6 commits into
Open
Conversation
* feat(amsterdam): Implement EIP-7843 SLOTNUM opcode * mario feedback
* fix(tests): minor updates to eip-7843 following ethereum#2007 * fix: account for slotnum in genesis creation * fix: append slot_number in fixture_loader.py
Replace stale GAS_BASE reference with GasCosts.OPCODE_SLOTNUM (= BASE) to match the opcode gas naming convention used across block instructions on forks/amsterdam. Also update the test-fork mixin to use gas_costs.BASE instead of the retired gas_costs.GAS_BASE.
kclowes
changed the title
kclowes
added
A-spec-specs
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #2853 +/- ##
===================================================
- Coverage 86.94% 86.94% -0.01%
===================================================
Files 586 586
Lines 35767 35777 +10
Branches 3362 3363 +1
===================================================
+ Hits 31098 31106 +8
- Misses 4010 4012 +2
Partials 659 659
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
marioevz
reviewed
May 13, 2026
Comment on lines
+706
to
+708
| # Clear block_access_list_hash if the fork doesn't require it | ||
| if not fork.header_bal_hash_required(): | ||
| header.block_access_list_hash = None |
Member
There was a problem hiding this comment.
cc @fselmo: is this change correct? It comes from the EIP-7843 so I wonder why it's only causing issues there and not in forks/amsterdam?
Contributor
There was a problem hiding this comment.
Hmm I'm not sure what the state of the code was when this was added but neither of these are necessary anymore. I removed them locally and everything seems to pass. I'm kind of confused on this check tbh, as well as the one below.
| ) | ||
| if bal != t8n_bal: | ||
| # If the BAL was modified, update the header hash | ||
| if bal != t8n_bal and fork.header_bal_hash_required(): |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Merge EIP-7843 into forks/amsterdam.
🔗 Related Issues or PRs
forks/amsterdam#2846✅ Checklist
just statictype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.Cute Animal Picture