fix(consume): add ethereum/execution-specs to SUPPORTED_REPOS#2849
Merged
marioevz merged 1 commit intoMay 13, 2026
Merged
Conversation
`FixtureDownloader.get_cache_path` versions the on-disk cache directory by release tag only when the release URL's owner/repo appears in `SUPPORTED_REPOS`. Otherwise it falls through to the unversioned `cache_folder / "other" / <archive_name>` path. When the BAL fixture release was moved from `ethereum/execution-spec-tests` to `ethereum/execution-specs` for `tests-bal@v7.1.0`, the new URL stopped being recognized as a release URL. A v7.0.0 download from a prior session, cached at `other/fixtures_bal/`, kept satisfying every subsequent request, including ones for v7.1.0. Consumers got stale fixtures with no warning. Add `ethereum/execution-specs` to `SUPPORTED_REPOS` so its release URLs hit the versioned cache path. Add regression tests covering `is_release_url` against every supported repo and asserting the new entry is present. Discovered while validating ethrex against tests-bal@v7.1.0: 76 SD-related ef-tests appeared to fail due to a spec mismatch, but the client was actually executing v7.1.0 semantics against v7.0.0 fixtures served by the stale cache. After clearing `~/.cache/ethereum-execution-spec-tests/cached_downloads/` all 2145 amsterdam tests pass.
e8bb28c to
7875f05
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #2849 +/- ##
================================================
Coverage 90.01% 90.01%
================================================
Files 539 539
Lines 32618 32618
Branches 3030 3030
================================================
Hits 29361 29361
Misses 2699 2699
Partials 558 558
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FixtureDownloader.get_cache_pathversions the on-disk cache directory by release tag only when the release URL's owner/repo appears inSUPPORTED_REPOS. Otherwise it falls through to the unversionedcache_folder / "other" / <archive_name>path.When the BAL fixture release was moved from
ethereum/execution-spec-teststoethereum/execution-specsfortests-bal@v7.1.0, the new URL stopped being recognized as a release URL. A v7.0.0 download from a prior session, cached atother/fixtures_bal/, kept satisfying every subsequentconsumerequest, including ones explicitly pointing at v7.1.0. Consumers got stale fixtures with no warning.This PR adds
ethereum/execution-specstoSUPPORTED_REPOSso its release URLs hit the versioned cache path (execution-specs/tests-bal@v7.1.0/fixtures_bal/).How this was found
While validating ethrex's bal-devnet-7 branch against
tests-bal@v7.1.0:https://github.com/ethereum/execution-specs/releases/download/tests-bal%40v7.1.0/fixtures_bal.tar.gzhas the correct v7.1.0 BAL (sender post-balance reflects no SD-refund per feat(spec-specs, tests): remove SD state gas refunds from EIP-8037 #2845).consumehad the v7.0.0 BAL (still applied the SD refund).+1,836,000 wei = +1× NEW_ACCOUNT × cpsb × gas_pricemismatch; the exact amount of the removed v7.0.0 SD refund._info.url.~/.cache/ethereum-execution-spec-tests/cached_downloads/made all 2,145 amsterdam tests pass on the same ethrex commit.So this was a stale-cache issue, not a spec or client bug. The fix prevents it from recurring once
execution-specs-hosted releases become standard.Changes
releases.py: addethereum/execution-specstoSUPPORTED_REPOS.tests/test_releases.py: add parametrized regression test foris_release_urlcovering every entry inSUPPORTED_REPOS, plus an explicit assertion thatethereum/execution-specsis present.Follow-up worth considering (not in this PR)
The
cache_folder / "other" / <archive_name>fallback inget_cache_pathis a latent footgun: any future release hosted on a repo not inSUPPORTED_REPOSwill silently collide with prior downloads sharing an archive filename. A defensive change, e.g. incorporating a hash of the URL into the "other" path, would close the door entirely. Happy to follow up in a separate PR if maintainers agree it's worth doing.Test plan
uv run pytest packages/testing/src/execution_testing/cli/pytest_commands/plugins/consume/tests/test_releases.py: 12/12 pass.uv run ruff check && uv run ruff format --check: clean.consumeagainsttests-bal@v7.1.0, observe 2,145/2,145 pass on ethrex bal-devnet-7.