feat(spec-specs, spec-tests): add EIP-7778 block gas accounting without refunds by LouisTsai-Csie · Pull Request #2840 · ethereum/execution-specs

LouisTsai-Csie · 2026-05-12T07:44:24Z

🗒️ Description

Merge changes necessary for implementing EIP-7778 into the forks/amsterdam branch.

This PR targets the EIP-7778 spec from ethereum/EIPs@3929b1a.

🔗 Related Issues or PRs

Tracking issue for EIP-7778 EIP-7778 Implementation Tracker: Block Gas Accounting without Refunds #1874
Tracking issue for merging SFId EIPs SFI EIPs Merge to forks/amsterdam #2846

✅ Checklist

All: Ran fast static checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
```
just static
```
All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
All: Considered updating the online docs in the ./docs/ directory.
All: Set appropriate labels for the changes (only maintainers can apply labels).
Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

Cute Animal Picture

codecov · 2026-05-13T05:38:25Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.94%. Comparing base (2037311) to head (c957227).

Additional details and impacted files

@@               Coverage Diff                @@
##           forks/amsterdam    #2840   +/-   ##
================================================
  Coverage            86.94%   86.94%           
================================================
  Files                  586      586           
  Lines                35764    35767    +3     
  Branches              3362     3362           
================================================
+ Hits                 31095    31098    +3     
  Misses                4010     4010           
  Partials               659      659

Flag	Coverage Δ
unittests	`86.94% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gurukamath

…unds (#1401) * feat(specs): add eip-7778 implementation * fix(specs) spliting receipt gas from block gas * revert receipt_gas_used * make sure that the calldata floor cost overwrites the tx gas before refund * receipt gas used after refunds * clarify variable naming @gurukamath * revert to using gas used after refunds for cumulative gas in receipt and add gasSpent to receipt * spec(amsterdam): fix code formatting --------- Co-authored-by: Guruprasad Kamath <guru241987@gmail.com>

* fix(tests): fix legacy tests to run with eip-7778 * fix(tests): check gas_spent and gas_used after Amsterdam

* feat(spec-tests): add eip-7778 for calldata checks * feat(spec-tests): post review - use code gas_cost function Co-authored-by: Louis Tsai <72684086+LouisTsai-Csie@users.noreply.github.com> * Apply suggestions from code review --------- Co-authored-by: Louis Tsai <72684086+LouisTsai-Csie@users.noreply.github.com> Co-authored-by: Mario Vega <marioevz@gmail.com>

The set iteration in `build_refund_tx` is non-deterministic due to Python's hash randomization, causing fixture output to vary between runs. Sort by enum value to ensure reproducible fixtures.

LouisTsai-Csie · 2026-05-13T06:14:53Z

I want to do a follow-up PR to remove expected_benchmark_gas_used in BenchmarkTest. This is not required anymore, as we introduce expected_gas_used in BlockchainTest.

execution-specs/packages/testing/src/execution_testing/specs/benchmark.py

Line 302 in 87c52b4

env: Environment = Field(default_factory=Environment)

LouisTsai-Csie · 2026-05-13T09:01:44Z

Some missing cases that we could do as follow-up PRs:

Refund tx OOG, revert the refund
refund quauls/exceeds gas_used_pre_refund // max_refund_quotient
storage x->y->0 refund (we have storage x->x->0 refund)
behavior at fork transition
successful at top frame but fails at subcall.
delegate to a contract that does the storage refund (two refunds)
authority do multiple authorization in same tx, resulting in cumulative refunds

danceratopz

Couple of small comments.

marioevz

LGTM, thanks!

Co-authored-by: Mario Vega <marioevz@gmail.com>

danceratopz

Small comment, not blocking for Merge: Skips should be illegal ;-)

LouisTsai-Csie changed the title ~~Eips/amsterdam/eip 7778~~ feat(specs-spec, tests): merge eip-7778 into forks/amsterdam May 12, 2026

LouisTsai-Csie added the A-spec-specs Area: Specification—The Ethereum specification itself (eg. `src/ethereum/*`) label May 12, 2026

LouisTsai-Csie changed the title ~~feat(specs-spec, tests): merge eip-7778 into forks/amsterdam~~ feat(spec-specs, tests): merge eip-7778 into forks/amsterdam May 12, 2026

LouisTsai-Csie added the C-feat Category: an improvement or new feature label May 12, 2026

spencer-tb mentioned this pull request May 12, 2026

SFI EIPs Merge to forks/amsterdam #2846

Open

8 tasks

LouisTsai-Csie changed the title ~~feat(spec-specs, tests): merge eip-7778 into forks/amsterdam~~ feat(spec-specs, spec-tests): add EIP-7778 block gas accounting without refunds May 13, 2026

LouisTsai-Csie marked this pull request as ready for review May 13, 2026 05:29

nerolation and others added 11 commits May 13, 2026 13:56

fix(tests): fix legacy tests to run with eip-7778 (#2048)

9d8334e

* fix(tests): fix legacy tests to run with eip-7778 * fix(tests): check gas_spent and gas_used after Amsterdam

feat(spec-tests): add basic eip7778 test (#2045)

83aee58

fix(tests): Fix gas used/spent in EIP-7702 tests (#2068)

30bb980

feat(spec-specs): use post refund gas in receipts in EIP-7778 (#2073)

b3ba21d

fix(test): Update refspec for EIP-7778 to match latest revision (#2093)

0dbecf2

feat(test-forks): Add EIP-7778

07adbc3

refactor(tests): Condition EIP-7778 tests to EIP inclusion

3dfb738

fix(test): use deterministic iteration order for refund types

4219c28

The set iteration in `build_refund_tx` is non-deterministic due to Python's hash randomization, causing fixture output to vary between runs. Sort by enum value to ensure reproducible fixtures.

doc: remove changelog md

f800304

fix: broken auth tx benchmark

dc52b58

LouisTsai-Csie force-pushed the eips/amsterdam/eip-7778 branch from 8ec956b to dc52b58 Compare May 13, 2026 06:38

doc: add eip checklist

9d88e40

gurukamath approved these changes May 13, 2026

View reviewed changes

danceratopz added the A-spec-tests Area: tests for specifications e.g. json_infra label May 13, 2026

danceratopz reviewed May 13, 2026

View reviewed changes

Comment thread docs/writing_tests/test_markers.md Outdated

Comment thread tests/amsterdam/eip7778_block_gas_accounting_without_refunds/test_gas_accounting.py

Comment thread tests/amsterdam/eip7778_block_gas_accounting_without_refunds/test_gas_accounting.py

fix: typo

1be47c0

marioevz approved these changes May 13, 2026

View reviewed changes

Comment thread tests/benchmark/compute/scenario/test_transaction_types.py Outdated

marioevz mentioned this pull request May 13, 2026

EIP-7778 Implementation Tracker: Block Gas Accounting without Refunds #1874

Open

20 tasks

Update tests/benchmark/compute/scenario/test_transaction_types.py

288837d

marioevz approved these changes May 13, 2026

View reviewed changes

Comment thread tests/benchmark/compute/scenario/test_transaction_types.py

Comment thread tests/benchmark/compute/scenario/test_transaction_types.py Outdated

marioevz added 2 commits May 13, 2026 11:32

Apply suggestions from code review

165181d

Co-authored-by: Mario Vega <marioevz@gmail.com>

Merge branch 'forks/amsterdam' into eips/amsterdam/eip-7778

c957227

danceratopz reviewed May 13, 2026

View reviewed changes

Comment thread tests/amsterdam/eip7778_block_gas_accounting_without_refunds/test_gas_accounting.py

danceratopz added the A-tests Area: Consensus tests. label May 13, 2026

danceratopz mentioned this pull request May 13, 2026

refactor(tests): replace runtime skip in EIP-7778 calldata test #2852

Merged

4 tasks

marioevz merged commit cd8c981 into forks/amsterdam May 13, 2026
26 checks passed

danceratopz mentioned this pull request May 13, 2026

Replace invalid field gas_used in expected_receipts in 7778 test #2855

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(spec-specs, spec-tests): add EIP-7778 block gas accounting without refunds#2840

feat(spec-specs, spec-tests): add EIP-7778 block gas accounting without refunds#2840
marioevz merged 17 commits into
forks/amsterdamfrom
eips/amsterdam/eip-7778

LouisTsai-Csie commented May 12, 2026 •

edited by danceratopz

Loading

Uh oh!

codecov Bot commented May 13, 2026 •

edited

Loading

Uh oh!

LouisTsai-Csie commented May 13, 2026

Uh oh!

LouisTsai-Csie commented May 13, 2026 •

edited

Loading

Uh oh!

danceratopz left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marioevz left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

danceratopz left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Conversation

LouisTsai-Csie commented May 12, 2026 • edited by danceratopz Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🗒️ Description

🔗 Related Issues or PRs

✅ Checklist

Cute Animal Picture

Uh oh!

codecov Bot commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

LouisTsai-Csie commented May 13, 2026

Uh oh!

LouisTsai-Csie commented May 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

danceratopz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marioevz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

danceratopz left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

LouisTsai-Csie commented May 12, 2026 •

edited by danceratopz

Loading

codecov Bot commented May 13, 2026 •

edited

Loading

LouisTsai-Csie commented May 13, 2026 •

edited

Loading