feat(benchmarks): add eth transfer cases for repricing#2837
feat(benchmarks): add eth transfer cases for repricing#2837jochem-brouwer wants to merge 8 commits into
Conversation
|
Changes: I split the original ether transfer test into two: Question: After review, i notice the scenario of |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #2837 +/- ##
===================================================
+ Coverage 88.62% 90.01% +1.38%
===================================================
Files 577 539 -38
Lines 35659 32618 -3041
Branches 3490 3030 -460
===================================================
- Hits 31604 29361 -2243
+ Misses 3492 2699 -793
+ Partials 563 558 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
fselmo
left a comment
There was a problem hiding this comment.
I'm not really sure how to properly test this (I can't locally) but I left some things I had questions on and some nits. @LouisTsai-Csie can you give a proper sanity check on the actual test run here? If so, can you give a final approve / review here?
|
Nice review and thanks @fselmo , we could not test it out without snapshot, i will test it in gas-benchmarks, review and merge. Edit: this is the latest benchmark payload generation with receipt check, it is a successful run: https://github.com/NethermindEth/gas-benchmarks/actions/runs/25806153732/job/75809369217 |
🗒️ Description
We have ether transfer benchmarks, but they're incomplete. We're missing:
For the latter two cases, we want to use pre-existing accounts from perf-devnet-3, mainnet, or jochemnet snapshots instead of creating them during pre-allocation. This keeps the accounts outside the client cache and prevents benchmark skewing.
Verification on gas-benchmarks with 300M: https://github.com/NethermindEth/gas-benchmarks/actions/runs/25720366344/job/75519841684
🔗 Related Issues or PRs
N/A.
✅ Checklist
just statictype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_frommarker.Cute Animal Picture