feat(exceptions): support external client exception mappers#2776
Draft
shrirajpawar4 wants to merge 2 commits into
Draft
feat(exceptions): support external client exception mappers#2776shrirajpawar4 wants to merge 2 commits into
shrirajpawar4 wants to merge 2 commits into
Conversation
New `validate` CLI command for running EEST fixtures directly against client EVM binaries, replacing Hive for execution correctness testing. Usage: validate health # health check all clients validate engine --client geth # engine tests validate state --client besu # state tests validate block --client nethermind # block tests Features: - 7 clients: geth, besu, nethermind, erigon, reth, ethrex, nimbus - Per-type Pydantic result models: StateTestResult, BlockTestResult, EngineTestResult with type-specific fields - Exception matching: maps client error strings to EEST exception types via ExceptionMapper, verifies correct exception for every invalid test (--no-exception-check to disable) - Cross-validation: lastBlockHash against fixture, lastPayloadStatus (VALID/INVALID) for engine tests - validate.toml config for client binary paths with per-type overrides (state-bin, block-bin, engine-bin) - Auto bin-workers and xdist tuning per client - Bundled Frontier sanity fixtures for health checks - Shared validate_helpers.py for validation logic Client binary PRs: - geth: ethereum/go-ethereum#34650 - erigon: erigontech/erigon#20315 - besu: besu-eth/besu#10184 - nethermind: NethermindEth/nethermind#11035 - reth: paradigmxyz/reth#23361 - ethrex: lambdaclass/ethrex#6445 - nimbus: status-im/nimbus-eth1#4101 - revm: bluealloy/revm#3544 Tracking issue: ethereum#2319
4 tasks
Contributor
|
this pr is impossible to review right now. you should wait until the pr it depends on is merged and then rebase. |
Author
|
yes okay |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Implements YAML-backed external exception mappers for client-owned error-string mappings.
Today, client exception mappings live in EEST Python source, so client teams need an execution-specs PR whenever their error strings change. This adds a small external mapper layer so client repos can
keep those mappings next to their client code while EEST keeps the built-in mappers as defaults.
External mappings are additive only:
UndefinedExceptionYAML v1 format:
This is stacked on #2622 because that PR introduces the new direct validate workflow where client-owned exception mappings are most useful for CI.
🔗 Related Issues or PRs
Fixes #2631.
Depends on #2622.
✅ Checklist
All: Ran fast static checks to avoid unnecessary CI fails:
just static
All: PR title adheres to the repo standard and starts type(scope):.
All: Considered updating the online docs in the ./docs/ directory.
All: Set appropriate labels for the changes (only maintainers can apply labels).
Focused checks run: