Skip to content

chore(ci): until amsterdam#1923

Closed
SamWilsn wants to merge 1 commit intoethereum:forks/amsterdamfrom
SamWilsn:tox-update-fork
Closed

chore(ci): until amsterdam#1923
SamWilsn wants to merge 1 commit intoethereum:forks/amsterdamfrom
SamWilsn:tox-update-fork

Conversation

@SamWilsn
Copy link
Copy Markdown
Contributor

Cute Animal Picture

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.51%. Comparing base (9e161b6) to head (c48eefa).
⚠️ Report is 129 commits behind head on forks/amsterdam.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           forks/amsterdam    #1923      +/-   ##
===================================================
- Coverage            82.61%   81.51%   -1.11%     
===================================================
  Files                  417      432      +15     
  Lines                26862    28623    +1761     
  Branches              2492     2699     +207     
===================================================
+ Hits                 22193    23333    +1140     
- Misses                4230     4851     +621     
  Partials               439      439              
Flag Coverage Δ
unittests 81.51% <ø> (-1.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It might need a rebase to incorporate the fill fixes.

@spencer-tb
Copy link
Copy Markdown
Contributor

Bump on this now we have BALs in forks/amsterdam.

Copy link
Copy Markdown
Contributor

@fselmo fselmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump on this now we have BALs in forks/amsterdam.

This needs to be rebased because py3 already has --until=Amsterdam (here) and we decided to keep it out of pypy3 because of memory issues and created #2029 instead.

I don't think there's anything left to merge here.

@spencer-tb
Copy link
Copy Markdown
Contributor

spencer-tb commented Jan 19, 2026

Cool CIFO: #1719 & #2029

@spencer-tb spencer-tb closed this Jan 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants