fix(release): exclude Playwright artefacts from the app tarball#136
Merged
Conversation
The e2e run drops `playwright-report/`, `test-results/`, `blob-report/` and `.playwright/` at the repo root. These are gitignored, but the tarball builder rsyncs the working tree (not `git archive`), so they leaked into the v1.1.0-alpha.3 build and more than doubled its size (516K vs the expected ~290K). Add them to RSYNC_EXCLUDES so a release built right after running the e2e suite stays clean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scripts/build-release-tarball.shrsyncs the working tree with an explicit exclude list (notgit archive). The Playwright e2e suite dropsplaywright-report/,test-results/,blob-report/, and.playwright/at the repo root — gitignored, but rsync copies them regardless. They leaked into the locally-built v1.1.0-alpha.3 tarball and more than doubled its size (516K vs the expected ~290K).Added the four artefact dirs to
RSYNC_EXCLUDES. Rebuilt locally: 516K → 289K (in line with alpha.1/alpha.2 at 230K/238K), noplaywright-report/test-resultsentries in the archive.The published v1.1.0-alpha.3 release asset was already replaced with a correctly-built (clean) tarball; this just prevents the regression for future releases.