chore: retire the legacy RetryPendingDeleteJob shim (#111)#132
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 156e8c20f4
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
The class only existed so Application::boot could $jobList->remove() it; live retries run via the Hot/Warm/Cold timed jobs (retryByAge). Verified on NC 33 that no RetryPendingDeleteJob is queued (background-job:list shows only Hot/Warm/Cold), and the plugin is pre-release so no other installs hold a stale legacy job — the boot remove() has done its job and can go. - Delete lib/BackgroundJob/RetryPendingDeleteJob.php. - Drop the $jobList->remove(RetryPendingDeleteJob::class) call from boot(). - Keep PendingDeleteRetryService::retry() (the no-age-filter entry point is still used by the admin manual-retry action in AdminController) and its test, renamed/recommented to reflect the real caller. PHPUnit 409 + Psalm green (baseline -1: the removed class's MissingOverride entry is gone); full Playwright 23/23 on NC 33 (boot still loads cleanly). Closes #111.
Jaggob
force-pushed
the
chore/111-retire-legacy-job
branch
from
156e8c2 to
7a51694
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
RetryPendingDeleteJobwas kept only soApplication::bootcould$jobList->remove(...)it; live retries run through the Hot/Warm/Cold timed jobs (retryByAge). Now that the cleanup window has passed it can go.Safe to remove now
occ background-job:listshows only the Hot/Warm/Cold jobs — noRetryPendingDeleteJobqueued (the boot-timeremove()already cleared it).Changes
lib/BackgroundJob/RetryPendingDeleteJob.php.$jobList->remove(RetryPendingDeleteJob::class)line fromboot()(still adds Hot/Warm/Cold).PendingDeleteRetryService::retry()— the no-age-filter entry point is still used by the admin "retry pending deletes" action (AdminController), not just the old job. Its test is kept, renamed/recommented to reflect that caller (caught by the test suite when I initially over-removed it).Acceptance
remove()callVerification
MissingOverrideAttributeentry).Application::bootstill loads cleanly.Closes #111.