Skip to content

fix: backward-compat for ESM etherpad #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SamTV12345 merged 1 commit into from
May 25, 2026
Merged

fix: backward-compat for ESM etherpad #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion eejs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict';

const eejs = require('ep_etherpad-lite/node/eejs/');
const eejs = require('ep_etherpad-lite/node/eejs');
Copy link
Copy Markdown

@qodo-free-for-open-source-projects qodo-free-for-open-source-projects Bot May 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Action required

1. eejs require change untested 📘 Rule violation ☼ Reliability

This PR changes the module resolution path in eejs.js as a bug fix for ESM compatibility, but no
regression test was added or updated to cover the behavior. Without an automated test, the
trailing-slash import can be reintroduced unnoticed and break under strict ESM exports resolution.
Agent Prompt 
## Issue description
A bug fix was made to remove the trailing slash from `require('ep_etherpad-lite/node/eejs/')`, but there is no regression test to prevent reintroducing the trailing-slash form.

## Issue Context
The change in `eejs.js` is intended to maintain backward compatibility while working with Node's strict ESM exports map resolution.

## Fix Focus Areas
- eejs.js[3-3]
- static/tests/backend/specs/esm-eejs-require.spec.js[1-120]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


exports.eejsBlock_mySettings = (hookName, args, cb) => {
args.content +=
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "ep_text_statistics",
"description": "Reading Ease and Grade Level of a pad",
"version": "0.0.60",
"version": "0.0.61",
"author": "johnyma22 (John McLear) <john@mclear.co.uk>",
"dependencies": {
"text-statistics": "^0.1.1"
Expand Down
Loading