Skip to content

[WIP] Add locales folder for translations #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[WIP] Add locales folder for translations #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80f1bf6
Initial plan
Copilot May 13, 2026
993b0f6
feat: add localization key for print button
JohnMcLear May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions locales/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"ep_print.toolbar.print": "Print"
}
5 changes: 5 additions & 0 deletions static/tests/frontend-new/specs/smoke.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,4 +10,9 @@ test.describe('ep_print', () => {
const padBody = await getPadBody(page);
await expect(padBody).toBeVisible();
});

test('print button exposes a localization key', async ({page}) => {
const printButton = page.locator('#printButton a.ep_print');
await expect(printButton).toHaveAttribute('data-l10n-id', 'ep_print.toolbar.print');
});
});
5 changes: 4 additions & 1 deletion templates/editbarButtons.ejs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
<li id="printButton" class="acl-write">
<a class="grouped-left ep_print" title="Print" onClick='printPad()'>
<a class="grouped-left ep_print"
title="Print"
data-l10n-id="ep_print.toolbar.print"
onClick='printPad()'>
<span class="buttonicon"></span>
</a>
</li>
Expand Down
Loading