Skip to content

bugc: add source maps for call setup instructions#188

Merged
gnidan merged 1 commit intocall-returnfrom
compiler-call-source-maps
Mar 11, 2026
Merged

bugc: add source maps for call setup instructions#188
gnidan merged 1 commit intocall-returnfrom
compiler-call-source-maps

Conversation

@gnidan
Copy link
Member

@gnidan gnidan commented Mar 11, 2026

Summary

  • Thread term.operationDebug through all call setup instructions (POP cleanup, PUSH return addr, MSTORE, push args, PUSH function addr)
  • Previously these had remark-only contexts, leaving them unmapped in tracing output
  • Now all call setup instructions carry the code context with the source range of the call expression, matching how other instruction generators use operationDebug
  • The JUMP itself retains its invoke context (not overwritten)

The call setup sequence (POP cleanup, PUSH return address,
MSTORE, push arguments, PUSH function address) was using
remark-only debug contexts, leaving these instructions
unmapped in tracing output. Now threads the call
terminator's operationDebug (which carries the source
code range for the call expression) through all setup
instructions, matching how other instruction generators
use operationDebug.
@github-actions
Copy link
Contributor

github-actions bot commented Mar 11, 2026

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-03-11 08:32 UTC

@gnidan gnidan merged commit 17a7b13 into call-return Mar 11, 2026
4 checks passed
@gnidan gnidan deleted the compiler-call-source-maps branch March 11, 2026 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant