docs: upgrade insecure http links to https#1111
Conversation
Signed-off-by: Anand raj <rajanand3307@gmail.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pigeio The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @pigeio. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi @pigeio , thanks for the consideration. However IMHO, I don’t think this update is really necessary.
The top of integrations page already clearly states that the listed tools and libraries are not maintained by the etcd project itself. We also don’t maintain redirects or external URLs (even http URLs may be considered insecure).
P/S: When backport for an upgrade, we normally only need to backport for the latest 3 release versions to keep them updated. I will let this PR open a bit of time to see if other reviewers have other comments, otherwise I will close it. Please feel free to pickup other issues in https://github.com/etcd-io/website/issues, we really appreciate your contribution. |
|
I'm going to disagree. I think with some changes this PR is pretty helpful; it calls attention to an external tool that shouldn't be listed for current versions of etcd because it's not maintained. See comments on the PR; if you resolve those, we can merge it. |
content/en/docs/v3.6/integrations.md
Outdated
| - [diwakergupta/jetcd](https://github.com/diwakergupta/jetcd) - Supports v2 | ||
| - [jurmous/etcd4j](https://github.com/jurmous/etcd4j) - Supports v2, Async/Sync, waits and SSL | ||
| - [AdoHe/etcd4j](http://github.com/AdoHe/etcd4j) - Supports v2 (enhance for real production cluster) | ||
| - [AdoHe/etcd4j](https://github.com/AdoHe/etcd4j) - Supports v2 (enhance for real production cluster) |
There was a problem hiding this comment.
Please delete the link instead of fixing it for 3.6, since v2 is no longer supported.
There was a problem hiding this comment.
This does mean that you'll also need to delete the referring text.
content/en/docs/v3.6/integrations.md
Outdated
| - [diwakergupta/jetcd](https://github.com/diwakergupta/jetcd) - Supports v2 | ||
| - [jurmous/etcd4j](https://github.com/jurmous/etcd4j) - Supports v2, Async/Sync, waits and SSL |
There was a problem hiding this comment.
You could also delete these links for 3.6 if you wanted.
content/en/docs/v3.7/integrations.md
Outdated
| - [diwakergupta/jetcd](https://github.com/diwakergupta/jetcd) - Supports v2 | ||
| - [jurmous/etcd4j](https://github.com/jurmous/etcd4j) - Supports v2, Async/Sync, waits and SSL | ||
| - [AdoHe/etcd4j](http://github.com/AdoHe/etcd4j) - Supports v2 (enhance for real production cluster) | ||
| - [AdoHe/etcd4j](https://github.com/AdoHe/etcd4j) - Supports v2 (enhance for real production cluster) |
There was a problem hiding this comment.
Please delete this link, and its referring text, instead of updating it.
Signed-off-by: Anand raj <rajanand3307@gmail.com>
@jberkus Thanks for the guidance! I have updated the PR based on your feedback. I removed the deprecated v2 tools (specifically etcd4j, jetcd, and boonproject) entirely from the v3.6 and v3.7 documentation to ensure users aren't guided toward unsupported libraries. The list for the newer versions is now cleaned up. Ready for re-review! |
I noticed several external links (specifically pointing to GitHub) were using the insecure
httpprotocol. This PR updates them tohttpsto prevent unnecessary redirects and improve security.Type of change: