Skip to content

docs: upgrade insecure http links to https#1111

Open
pigeio wants to merge 2 commits intoetcd-io:mainfrom
pigeio:docs-upgrade-http-links
Open

docs: upgrade insecure http links to https#1111
pigeio wants to merge 2 commits intoetcd-io:mainfrom
pigeio:docs-upgrade-http-links

Conversation

@pigeio
Copy link

@pigeio pigeio commented Jan 28, 2026

I noticed several external links (specifically pointing to GitHub) were using the insecure http protocol. This PR updates them to https to prevent unnecessary redirects and improve security.

Type of change:

  • Documentation update

Signed-off-by: Anand raj <rajanand3307@gmail.com>
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pigeio
Once this PR has been reviewed and has the lgtm label, please assign jmhbnz for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

Hi @pigeio. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@wendy-ha18
Copy link
Contributor

wendy-ha18 commented Jan 28, 2026

Hi @pigeio , thanks for the consideration. However IMHO, I don’t think this update is really necessary.

  • This page is intended to be a community-sourced list of external tools, so developers can quickly discover ecosystem integrations around etcd. It doesn’t imply that etcd maintainers recommend or endorse these tools.

The top of integrations page already clearly states that the listed tools and libraries are not maintained by the etcd project itself. We also don’t maintain redirects or external URLs (even http URLs may be considered insecure).

  • In addition, the library you updated AdoHe/etcd4j is a third-party Java client that targets the etcd v2 API, which is legacy and deprecated. Most clients today are using etcd v3 API I believe.

P/S: When backport for an upgrade, we normally only need to backport for the latest 3 release versions to keep them updated.

I will let this PR open a bit of time to see if other reviewers have other comments, otherwise I will close it.

Please feel free to pickup other issues in https://github.com/etcd-io/website/issues, we really appreciate your contribution.

@jberkus
Copy link
Contributor

jberkus commented Jan 29, 2026

I'm going to disagree. I think with some changes this PR is pretty helpful; it calls attention to an external tool that shouldn't be listed for current versions of etcd because it's not maintained. See comments on the PR; if you resolve those, we can merge it.

- [diwakergupta/jetcd](https://github.com/diwakergupta/jetcd) - Supports v2
- [jurmous/etcd4j](https://github.com/jurmous/etcd4j) - Supports v2, Async/Sync, waits and SSL
- [AdoHe/etcd4j](http://github.com/AdoHe/etcd4j) - Supports v2 (enhance for real production cluster)
- [AdoHe/etcd4j](https://github.com/AdoHe/etcd4j) - Supports v2 (enhance for real production cluster)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete the link instead of fixing it for 3.6, since v2 is no longer supported.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does mean that you'll also need to delete the referring text.

Comment on lines 45 to 46
- [diwakergupta/jetcd](https://github.com/diwakergupta/jetcd) - Supports v2
- [jurmous/etcd4j](https://github.com/jurmous/etcd4j) - Supports v2, Async/Sync, waits and SSL
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could also delete these links for 3.6 if you wanted.

- [diwakergupta/jetcd](https://github.com/diwakergupta/jetcd) - Supports v2
- [jurmous/etcd4j](https://github.com/jurmous/etcd4j) - Supports v2, Async/Sync, waits and SSL
- [AdoHe/etcd4j](http://github.com/AdoHe/etcd4j) - Supports v2 (enhance for real production cluster)
- [AdoHe/etcd4j](https://github.com/AdoHe/etcd4j) - Supports v2 (enhance for real production cluster)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete this link, and its referring text, instead of updating it.

Signed-off-by: Anand raj <rajanand3307@gmail.com>
@pigeio
Copy link
Author

pigeio commented Jan 30, 2026

I'm going to disagree. I think with some changes this PR is pretty helpful; it calls attention to an external tool that shouldn't be listed for current versions of etcd because it's not maintained. See comments on the PR; if you resolve those, we can merge it.

@jberkus Thanks for the guidance!

I have updated the PR based on your feedback. I removed the deprecated v2 tools (specifically etcd4j, jetcd, and boonproject) entirely from the v3.6 and v3.7 documentation to ensure users aren't guided toward unsupported libraries.

The list for the newer versions is now cleaned up. Ready for re-review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants