build(deps-dev): update docsy requirement from 0.12.0 to 0.13.0#1091
build(deps-dev): update docsy requirement from 0.12.0 to 0.13.0#1091
Conversation
dependabot
bot
added
dependencies
|
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/ok-to-test |
|
This doesn't break anything I can tell, but it does change the look & feel somewhat. Opinions, @nate-double-u @ronaldngounou @wendy-ha18 ? |
|
On my end I am not noticing any appearance difference. What do you notice? |
|
Just some layout and character spacing. Stuff feels more sparse. |
Updates the requirements on [docsy](https://github.com/google/docsy) to permit the latest version. - [Release notes](https://github.com/google/docsy/releases) - [Commits](https://github.com/google/docsy/commits/bbf68d4caae52e8c9a89964c3d04b383ee678d44) --- updated-dependencies: - dependency-name: docsy dependency-version: bbf68d4caae52e8c9a89964c3d04b383ee678d44 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/docsy-0.13.0
branch
from
292953f to
de11446
Compare
|
It does look different—different spacing and font weight. I don't oppose the changes, considering that we may want to stay on the latest version. |
|
I just noticed a comment in the packages file:
@nate-double-u @chalin do you know what that's about? Should we remove the mkdirp requirement? |
Signed-off-by: Nate W <natew@cncf.io>
|
It didn't look like removing |
|
New on the left: 
|
|
/retest |
There was a problem hiding this comment.
Yes there have been some style changes, in particular improved color contrast in light and dark modes, and falling back to Bootstrap defaults (that is, stripping unnecessary Docsy overrides). For the full scoop, see:
I'd say that this PR can land.
If you want I can submit some followup PR(s) with proper adjustments for 0.13.0. Let me know.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chalin, dependabot[bot] The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jberkus @nate-double-u et all: seems like this is ready to merge, any objections to doing so? |
6 participants
Updates the requirements on docsy to permit the latest version.
Commits
You can trigger a rebase of this PR by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)