Skip to content

Use static list of keys in model#21486

Open
serathius wants to merge 1 commit intoetcd-io:mainfrom
serathius:robustness-static
Open

Use static list of keys in model#21486
serathius wants to merge 1 commit intoetcd-io:mainfrom
serathius:robustness-static

Conversation

@serathius
Copy link
Copy Markdown
Member

@serathius serathius commented Mar 15, 2026

Continuation of #19973
PoC for #21133

After improvements in #21488

goos: linux
goarch: amd64
pkg: go.etcd.io/etcd/tests/v3/robustness/validate
cpu: AMD Ryzen Threadripper PRO 3945WX 12-Cores     
                                                               │   old.txt    │               new.txt               │
                                                               │    sec/op    │   sec/op     vs base                │
ValidateLinearizableOperations/SequentialSuccessPuts-24           17.14m ± 3%   15.09m ± 3%  -11.97% (p=0.000 n=10)
ValidateLinearizableOperations/SequentialFailedPuts-24            15.68m ± 2%   10.89m ± 1%  -30.57% (p=0.000 n=10)
ValidateLinearizableOperations/ConcurrentFailedPutsWithRead-24    16.61m ± 2%   12.92m ± 2%  -22.23% (p=0.000 n=10)
ValidateLinearizableOperations/ConcurrentFailedPuts-24            18.42m ± 1%   12.09m ± 3%  -34.38% (p=0.000 n=10)
ValidateLinearizableOperations/BacktrackingHeavy-24              26.638m ± 1%   1.521m ± 1%  -94.29% (p=0.000 n=10)
geomean                                                           18.54m        8.284m       -55.32%

@k8s-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.46%. Comparing base (be3acf4) to head (458d1cf).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

see 23 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #21486      +/-   ##
==========================================
+ Coverage   68.40%   68.46%   +0.05%     
==========================================
  Files         428      428              
  Lines       35372    35372              
==========================================
+ Hits        24196    24216      +20     
+ Misses       9773     9748      -25     
- Partials     1403     1408       +5     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be3acf4...458d1cf. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@serathius serathius force-pushed the robustness-static branch 4 times, most recently from 66e9ace to 42756c1 Compare March 23, 2026 16:28
Signed-off-by: Marek Siarkowicz <siarkowicz@google.com>
@k8s-ci-robot
Copy link
Copy Markdown

@serathius: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-integration-2-cpu-arm64 458d1cf link true /test pull-etcd-integration-2-cpu-arm64
pull-etcd-robustness-arm64 458d1cf link true /test pull-etcd-robustness-arm64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

2 participants