[etcd-operator] helm chart

[luismacosta]

[etcd-operator] helm chart: based on folder config, here is an idea for the helm chart

validate chart:

➜  cd helm
➜  helm lint .  

==> Linting .

1 chart(s) linted, 0 chart(s) failed

➜  helm template . --name-template etcd-operator -n etcd-operator -f values.yaml > test.yaml --debug

install.go:224: 2025-03-04 17:11:08.163499 +0000 WET m=+0.021731792 [debug] Original chart version: ""
install.go:241: 2025-03-04 17:11:08.16369 +0000 WET m=+0.021923126 [debug] CHART PATH: /Users/luis.costa/projects/etcd-operator/helm

➜  ~ kubectl create ns etcd-operator
namespace/etcd-operator created

➜  ~ kubectl apply -f /Users/luis.costa/projects/etcd-operator/helm/test.yaml  -n etcd-operator
serviceaccount/controller-manager created
clusterrole.rbac.authorization.k8s.io/etcd-operator-editor-role created
clusterrole.rbac.authorization.k8s.io/etcd-operator-viewer-role created
clusterrole.rbac.authorization.k8s.io/etcd-operator-metrics-auth-role created
clusterrole.rbac.authorization.k8s.io/metrics-reader configured
clusterrole.rbac.authorization.k8s.io/etcd-operator-role created
clusterrolebinding.rbac.authorization.k8s.io/metrics-auth-rolebinding created
clusterrolebinding.rbac.authorization.k8s.io/etcd-operator-rolebinding created
role.rbac.authorization.k8s.io/etcd-operator-leader-election-role created
rolebinding.rbac.authorization.k8s.io/etcd-operator-leader-election-rolebinding created

@ahrtr @ivanvc @gdasson

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: luismacosta
Once this PR has been reviewed and has the lgtm label, please assign justinsb for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @luismacosta. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ivanvc]

Thanks for the pull request, @luismacosta. We discussed this PR in our community meeting today.

We're currently using Kustomize to generate the Kubernetes payloads. However, we would love to incorporate a Helm chart as it has a lot of traction in the community. Because of that, there's a lot of overlap and repetition with the YAML payloads we have in https://github.com/etcd-io/etcd-operator/tree/main/config. Would it be possible to re-use them? I'm not sure if it's possible to have a Helm chart co-existing with Kustomize without a tool like Helm X. Or, maybe we could use chartify to generate the Chart from the Kustomization files.

[luismacosta]

Thanks for the pull request, @luismacosta. We discussed this PR in our community meeting today.

We're currently using Kustomize to generate the Kubernetes payloads. However, we would love to incorporate a Helm chart as it has a lot of traction in the community. Because of that, there's a lot of overlap and repetition with the YAML payloads we have in https://github.com/etcd-io/etcd-operator/tree/main/config. Would it be possible to re-use them? I'm not sure if it's possible to have a Helm chart co-existing with Kustomize without a tool like Helm X. Or, maybe we could use chartify to generate the Chart from the Kustomization files.

Hello,

kustomize.yaml should not be present in the helm chart. We can remove the folder config and define a way to generate the helm templates as you've mentioned. An official docker image for etcd-operator and releases in this github repo for helm chart is something to take into consideration.

[luismacosta]

Hi, @luismacosta. Do you want to open a new pull request? Or, I suggest properly rebasing with the main branch. This PR has 50 commits that are unrelated changes in our main branch.

Thanks :)

Yes it was a problem with the rebase. The PR is now ok to be reviewed. 20 files, related to helm chart. I've addressed all changes that you've requested

[ivanvc]

Yes it was a problem with the rebase. The PR is now ok to be reviewed. 20 files, related to helm chart. I've addressed all changes that you've requested

Hi, @luismacosta. This pull request is becoming very noisy. You didn't correctly rebase your branch. You have 69 commits, many of them don't belong to your branch.

I also see that you are reviewing your own pull request and still making changes. I would like to suggest that if you are not ready to open the pull request, you close it, work on it in your local environment, and open it up when you are ready to have it reviewed. Thank you.

[luismacosta]

tests completed. new PR #95